Improve Lisp binding#848
Merged
Merged
Conversation
Owner
Author
|
If we dissociate function arguments evaluation from parameters binding we don't need a special case for macros, so we can merge |
Owner
Author
|
We couldn't have optional args before: This is now fixed: |
Owner
Author
|
This last commit change the evaluation order but I think the new order is fine: Before: After: |
Owner
Author
|
Now that This works now: |
Owner
Author
|
With the |
Owner
Author
|
With |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eval::eval_argscalls out ofenv::inner_envin interpreterenv::function_envandenv::macro_envin interpreterenv::inner_envtoenv::bindin interpretereval::applyin interpreterapplyspecial form without double eval bugfoldspecial form