Skip to content

Disable pi thinking for DeskTalk agent sessions#53

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/disable-thinking-in-session
Draft

Disable pi thinking for DeskTalk agent sessions#53
Copilot wants to merge 3 commits into
mainfrom
copilot/disable-thinking-in-session

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

DeskTalk’s pi agent wiring was allowing session thinking/reasoning to remain enabled, which slows interactive use. This change forces DeskTalk-managed pi sessions to run with thinking disabled across session creation, restore, and provider/model sync.

  • Session defaults

    • Introduce DeskTalk-specific session handling that forces pi session thinking level to off.
    • Apply this consistently for newly created sessions and reopened sessions.
  • Preference sync behavior

    • Reapply off after provider/model synchronization so model switches do not re-enable reasoning.
  • Coverage

    • Add focused unit coverage around preference sync to ensure thinking stays disabled when the active model changes.
if (
  !this.session.model ||
  this.session.model.provider !== targetModel.provider ||
  this.session.model.id !== targetModel.id
) {
  await this.session.setModel(targetModel);
}

disableSessionThinking(this.session);

Copilot AI and others added 3 commits April 14, 2026 08:06
Agent-Logs-Url: https://github.com/vincentdchan/DeskTalk/sessions/675152a0-1cf1-48f0-8d8b-792a4dc6c0aa

Co-authored-by: vincentdchan <2352832+vincentdchan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/vincentdchan/DeskTalk/sessions/675152a0-1cf1-48f0-8d8b-792a4dc6c0aa

Co-authored-by: vincentdchan <2352832+vincentdchan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/vincentdchan/DeskTalk/sessions/675152a0-1cf1-48f0-8d8b-792a4dc6c0aa

Co-authored-by: vincentdchan <2352832+vincentdchan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants