ci: fix code scanning alerts (workflow permissions + test assertion)#16
Merged
Conversation
…tion Add a top-level `permissions: contents: read` block to the CI workflow so the GITHUB_TOKEN runs with least privilege instead of the broad default, resolving the two CodeQL actions/missing-workflow-permissions alerts. Replace the `"ffmpeg.org" in hint` substring assertion in the unknown-OS hint test with an exact comparison. The substring form tripped CodeQL's py/incomplete-url-substring-sanitization rule (a real concern for URL validation, a false positive in a test); the exact check is also stronger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the 3 pre-existing CodeQL alerts on
main(none were introduced by the GUI PR).Changes
.github/workflows/ci.yml- add a top-levelpermissions: contents: readblock. The workflow only checks out and runs tests, so least privilege is correct. Clears bothactions/missing-workflow-permissionsalerts.tests/test_dependencies.py- replaceassert "ffmpeg.org" in hintwith an exact comparison (hint.strip() == "Download: https://ffmpeg.org/download.html"). The substring form trippedpy/incomplete-url-substring-sanitization(a real risk for URL validation, a false positive in a test assertion); the exact check is also stronger.Testing