Repository navigation
Conversation
XXX of the catalog's 805 keys. The rest are product names that every other locale also leaves in English, and they fall back to English as CONTRIBUTING asks. Verified: every `ko` value carries the placeholders its English key does (checked by script, 0 mismatches), no existing locale's value changed, and the catalog round-trips byte-identically so the diff is additions only. `make test` passes on macOS 27.
Owner
|
Thank you @sylph2nd — and I want to be clear this was close, because it was. I'm taking #305. The deciding factors were not translation quality:
Your Korean is good, and in places I prefer it: the 해요체 Concretely: would you review #305 now that it's merged and send a follow-up for the lines you'd word differently? Register is a real choice and I'd rather have it argued than defaulted, and you clearly have the ear for it. I'd merge that. Closing this one so the two don't drift apart, not because the work wasn't good. |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Korean (
ko) as the eleventh language Codenotch can be switched to. Korean is offered in Settings › General › Language as "한국어", and every one of the catalog's 805 keys now carries akovalue. 19 of those are product names and identifiers (Opus, Sonnet, VS Code, Dock,Authorization, the OpenAI base URL, …) that stay in English, which is how every other locale files them too.The translation follows Apple's Korean macOS vocabulary (메뉴 막대, 키체인, 손쉬운 사용, 로그인 시 열기) and keeps one Korean word per app concept: Keep open → 열어 두기, pin-to-display → 고정, Always show → 항상 표시, Watch/Critical limit → 주의/위험 기준, provider → 제공자, endpoint → 엔드포인트. Buttons and labels end in noun form, descriptions in 합쇼체 (
~합니다), instructions in~하세요. Em dashes in the source were rewritten as full stops or colons; no emoji, no exclamation marks.After the first pass the whole set went through two review rounds: a rule-based Korean spell checker (Nara/PNU) over all values in 18 chunks, and a translationese pass that removed direct-from-English patterns (
~을 통해,~의 경우, have → 가지다, mixed politeness levels) and unified terms across strings. 42 strings changed in review; a mistranslation of "main Codex window" (a limit window, not a GUI window) was caught there.Changes
Sources/Localizable.xcstrings:kovalues for all 805 keys. No existing locale's value changed and key order is untouched, so the diff is additions only. Placeholders match the English key one-for-one (checked by script, 0 mismatches); the one string whose word order had to move (%lld%% of its %@ limit used.) uses positional%1$lld/%2$@the way zh-Hans does.Sources/Settings/AppLanguage.swift: newkorean = "ko"case with locale, title "한국어" and the shared description.Sources/Info.plist,project.yml:koadded toCFBundleLocalizations/knownRegionsso the build emitsko.lproj.Tests/AppLanguageTests.swift:testKoreanIsOfferedAndMapsToKoandtestApplyKoreanStoresTheOverride, mirroring the Japanese cases.Tests/LocalizationTests.swift:testEveryOfferedLanguageResolvesexpectskoin the language list.Test Plan
make test): 1712 tests, 0 failures, 3 skippedko.lproj/Localizable.stringswith 805 entrieskovalue, byte-identical round trip of the JSON, no non-kochanges againstmainScreenshots / Screen Recordings
Notes for review
Terms where Apple's Korean UI and the official orthography disagree were resolved in favour of Apple's UI: 데스크탑 (not 데스크톱), 임계값 (not 임곗값). "피커" (picker) appears in five settings descriptions; "팝업 메뉴" is the alternative if a reviewer prefers it. The phone-pairing step "Tap Scan QR Code" is rendered as "'QR Code 스캔' 탭하기" and should be aligned with whatever the iOS companion app actually shows.