Repository navigation
Conversation
A full-screen video, game or slideshow had the notch open over it, and on the taskbar's edge floating a taskbar's height up, since Windows keeps the work area as it was when the taskbar steps aside. Now a foreground window filling the notch's monitor folds it to the pill, as on the Mac; hovering still opens it. Meanwhile the notch sits on the monitor's own edge, gliding there over the fold's 360 ms rather than jumping. Appearance gains the Mac's Fold for full-screen apps switch, on by default.
vinzdg#375 gathered Settings' first reads into one list that the window waits on before it shows, so the fold switch's read joins that list instead of running after it. main.rs takes vinzdg#388's carry module beside this one.
Contributor
Author
|
Merged main in to fix the conflicts with #375 and #388. The fold switch now loads with the rest of Settings, and main.rs keeps the carry module next to the full-screen one. The PR's own changes are the same as before. This PR and #390 edit some of the same lines, so whichever you merge second, I'll merge main into the other again. |
3 tasks done
The full-screen poll asked Tauri for the notch's HWND on every platform, and `hwnd()` exists only on Windows, so the Linux build from vinzdg#294 stopped there. The lookup moves into the Windows `read`, and the helpers only that `read` uses are marked as diag.rs marks its own, so Linux builds without new dead-code warnings.
vinzdg#390 retired the move handle and gave the fold the settings button's order: the disc turns back into its arc, the arc goes home, then the notch folds. A full-screen app now joins that as a second reason to fold, and its immediate fold cancels the arc's pending tuck as well as the fold timer. The full-screen commands stay in the handler list without the drop zones', and the Settings switch without the handle's.
Contributor
Author
vinzdg#394 added Settings' two reset-notification switches at the same three places this branch adds the fold switch: where each is declared, drawn and first read. All three keep both.
Contributor
Author
|
@vinzdg this has been ready before each of the last three rounds, but each time a lower-numbered PR touching the same files went in just ahead of it (#388, then #390, then #394), so it was in conflict by its turn. It's merged with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full-screen video, game or slideshow had the notch open over it, and the topmost watchdog (#322) put it back on top. On the taskbar's edge it also floated a taskbar's height above the bottom of the screen, over the picture: placement uses the work area, and Windows leaves that as it was when a full-screen app sends the taskbar away.
What changes
FullScreenDetector): the foreground window fills its monitor to within 4 px, polled every 400 ms so a video going full screen in the browser already in front is caught too. A maximised window does not count, even with an auto-hidden taskbar (the Mac's Add a "Fold for full-screen apps" toggle #181), nor does the desktop.Overlap: #375 and #390 (mine, still open) change neighbouring lines in
settings.html,notch.htmlandmain.rs. Whichever lands second addsfoldFullScreen.refresh()to #375'sfirstlist and keepsfullScreenin #390'sfoldAllowed; I'll do that rebase.Tests
cargo test(153),cargo clippy --all-targets(no new warnings), the page check