Repository navigation
Windows: read the numeric zone labels agy prints - #432
Open
Sargares22 wants to merge 1 commit into
Open
Sargares22 wants to merge 1 commit into
Sargares22 wants to merge 1 commit into
Conversation
A timezone with no abbreviation (Bangkok, Sri Lanka, Nepal) is labelled by its UTC offset, so under ConPTY agy 1.3.0 prints "2026-10-08 07:23 +07". vinzdg#428 required the label to be alphabetic, and every Antigravity CLI reading on such a host failed with "Invalid quota reset timezone". "±HH" and "±HHMM" labels are now read as the offset they state. An offset, unlike an abbreviation, is unambiguous, and it is the one the CLI applied, so the host timezone is not consulted. Abbreviations are resolved as before, and any other shape of label is still an error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Confirming this on another zone and CLI version, in case it helps. On Windows 11 with "E. South America Standard Time" (UTC−03:00) and agy 1.3.2, the ring was stuck on "Invalid quota reset timezone". The CLI prints a negative offset under ConPTY, captured through On |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a Windows host whose timezone has no abbreviation, the Antigravity CLI ring goes stale with "Invalid quota reset timezone" and never recovers. Follow-up to #428.
agylabels such a zone by its UTC offset. This is whatagy --sandbox --print-timeout 30s --print /usagereturns under ConPTY with agy 1.3.0 on "SE Asia Standard Time" (UTC+07:00), captured through the existinglive_quotatest:parse_reset_time_withrequired the label to be ASCII-alphabetic, so+07was rejected and every reading failed.Changes
windows/codenotch/src/agy_cli.rs: a±HHor±HHMMlabel is read as the offset it states. An offset, unlike an abbreviation, is unambiguous, and it is the one the CLI applied, so the host timezone is not consulted for it.UTC/GMT/Zand RFC 3339 take the same paths as before. Any other shape of label (+7,+07:00,+0760,+1401,UTC+7, ...) is still "Invalid quota reset timezone".localized_reset_rejects_malformed_textlisted+11as malformed; it is now a valid label and moved to the accepted cases.Only
+07was observed. The±HHMMform (+0530,+0545) is inferred from how Go formats zones without a name; I have no host in such a zone to confirm it.Test Plan
Windows 11 ARM64, in
windows/:cargo test --locked -p codenotch agy_cli— 14 passed, 1 ignoredcargo test --locked -p codenotch agy_cli::tests::live_quota -- --ignored— failed with "Invalid quota reset timezone" before the change, passes after (4 quota windows)cargo test --locked(whole workspace) — 186 passed, run before the last review touch-ups to the same fileNew tests: a full report with the rows above checked against exact UTC instants, a table of numeric labels of both signs and both widths, and malformed numeric labels. None depend on the host timezone.
Screenshots / Screen Recordings
None; no visual change.
🤖 Generated with Claude Code