Repository navigation
perf: Reduce redundant cursor geometry calculations - #442
Open
itradesize wants to merge 1 commit into
Open
itradesize wants to merge 1 commit into
itradesize wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce unnecessary CPU usage during mouse movement by reusing cursor geometry calculations within each mouse event.
Runtime profiling identified repeated geometry and model calculations in cursor callbacks as a major source of CPU activity, particularly in multi-display configurations.
This optimization is independent of PR #431.
Changes
No mouse-event throttling, artificial delays, or animation quality reductions were introduced.
Performance observations
Observed on an Apple Silicon MacBook Pro with four displays.
These are informal Activity Monitor observations during normal usage, not controlled benchmarks.
The Debug-to-Release improvement comes from compiler optimization and is not attributed to this PR.
The relevant comparison for this source change is between the two Release builds.
Test Plan
make test-ci)Additional validation:
-Oand whole-module optimization.git diff --checkpassed.Automated tests were intentionally not run during final preparation.
Screenshots / Screen Recordings
No visual UI changes.
The optimization preserves existing notch appearance and interactions while reducing redundant CPU work.