Fix nurbs example: drop .array_len() on flat slices, add umin/umax/vm…#29
Merged
Conversation
…in/vmax The renderer rejected `uknot`, `vknot`, and every `trimcurves.*` array attribute with E6007 (wrong type), then E6020 (required attributes missing) because the rejected ones look absent. Cause: the example called `.array_len(N)` on these, which encodes the value as a single fixed-size N-tuple (`type[N]`, count=1, arraylength=N). NSI expects flat slices for them: `count=N, arraylength=0`, i.e. plain `f32_slice!` / `i32_slice!` without `.array_len()`. Use `.array_len(N)` only for parameters whose type is a fixed-size N-tuple (e.g. `screen.resolution = int[2]`). Also add `umin`/`umax`/`vmin`/`vmax` (default 0..1) to mirror `RiNuPatch`'s explicit surface domain. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in/vmax
The renderer rejected
uknot,vknot, and everytrimcurves.*array attribute with E6007 (wrong type), then E6020 (required attributes missing) because the rejected ones look absent. Cause: the example called.array_len(N)on these, which encodes the value as a single fixed-size N-tuple (type[N], count=1, arraylength=N). NSI expects flat slices for them:count=N, arraylength=0, i.e. plainf32_slice!/i32_slice!without.array_len().Use
.array_len(N)only for parameters whose type is a fixed-size N-tuple (e.g.screen.resolution = int[2]).Also add
umin/umax/vmin/vmax(default 0..1) to mirrorRiNuPatch's explicit surface domain.