Fix build_visit --print-files missing some library files - #21091
Merged
Merged
Conversation
biagas
force-pushed
the
bugfix/biagas/build_visit_print_missing_files
branch
from
August 7, 2026 15:19
736a97c to
0802f0a
Compare
The `--print` option keys off the main libraries NAME var (eg BV_LLVM). Some modules that build multiple libraries had seconary libraries whose var's had completely unrelated names. Ensure secondary library VARS prefixed with main module name so that logic related to `--print` will work correctly. Fixed bv_qt so that the `tools` and `svg` libraries have their checksums verified when already downloaded/present in the build dir.
biagas
force-pushed
the
bugfix/biagas/build_visit_print_missing_files
branch
from
August 7, 2026 17:57
0802f0a to
28dfbed
Compare
brugger1
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #20913.
The logic used for the
--print-filesand--print-files-htmloption keys off a main module's library name.For modules that build secondary libraries, the secondary libraries were skipped if their vars describing file, etc didn't also include the main library's name. I updated such modules.
I also fixed the QT module so that it's SVG and TOOLS libraries checksums were verified if the tarballs had already been downloaded.
Type of change
[ ] New feature[ ] Documentation update[ ] OtherHow Has This Been Tested?
In a directory where I had previously ran build_visit to build all libraries, I ran
build_visit --print-filesand verified the list of files against the tarballs in the directory. Similar for--print-files-html.Checklist:
[ ] I have commented my code where applicable.[ ] I have made corresponding changes to the documentation.[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to [protocol or public interfaces][3] in an RC branch.