Fix pick issue with Degenerate Hexes. - #21142
Conversation
f729c73 to
0add9ff
Compare
|
I think this explains why I was seeing very long query times in the queries I added to test degenerate hex logic in #20364. I noticed the new queries I added took ~5 mins and should have taken only a second. Thanks for fixing 💪. |
0add9ff to
a02fd49
Compare
Am I missing something? I am only seeing a Volume query in your PR, I don't see how my changes would affect the speed of that query. |
Hmm...no...maybe I am missing something 😉. But, now that we're clear about the differences, perhaps it is worth a look at those queries too as they take way too long given what I know about what it should really take. |
Added vtkVisItUtility::EvaluatePosition, which has a fallback for degnerate cells when vtkCell::EvaluatePosition fails. Updated calls to vtkCell::EvaluatePosition to use the new method where necessary. Fixed an bit of logic using integer division when it should have been double. It was causing picks to bog down and take quite awhile to return results. 45 seconds for a pick now down to 0.006 in testing.
a02fd49 to
94ca263
Compare
Description
Resolves #19645
Added vtkVisItUtility::EvaluatePosition, which has a fallback for degenerate cells when vtkCell::EvaluatePosition fails.
Updated calls to vtkCell::EvaluatePosition to use the new method where necessary.
Fixed a bit of logic using integer division when it should have been double. It was causing picks to bog down and take quite awhile to return results. 45 seconds for a pick now down to 0.006 in testing.
Type of change
How Has This Been Tested?
Reminders:
Checklist: