Skip to content

Fix pick issue with Degenerate Hexes. - #21142

Merged
biagas merged 1 commit into
developfrom
bugfix/biagas/node_pick_degen_hexes
Sep 16, 2026
Merged

biagas merged 1 commit into
developfrom
bugfix/biagas/node_pick_degen_hexes

Conversation

@biagas

@biagas biagas commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Resolves #19645
Added vtkVisItUtility::EvaluatePosition, which has a fallback for degenerate cells when vtkCell::EvaluatePosition fails.
Updated calls to vtkCell::EvaluatePosition to use the new method where necessary.
Fixed a bit of logic using integer division when it should have been double. It was causing picks to bog down and take quite awhile to return results. 45 seconds for a pick now down to 0.006 in testing.

Type of change

  • Bug fix~~
  • New feature~~
  • Documentation update~~
  • Other~~

How Has This Been Tested?

Reminders:

  • Please follow the style guidelines of this project.
  • Please perform a self-review of your code before submitting a PR and asking others to review it.
  • Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

  • I have commented my code where applicable.~~
  • I have updated the release notes.~~
  • I have made corresponding changes to the documentation.~~
  • I have added debugging support to my changes.~~
  • I have added tests that prove my fix is effective or that my feature works.~~
  • I have confirmed new and existing unit tests pass locally with my changes.~~
  • I have added new baselines for any new tests to the repo.~~
  • I have NOT made any changes to protocol or public interfaces in an RC branch.~~

@biagas
biagas force-pushed the bugfix/biagas/node_pick_degen_hexes branch from f729c73 to 0add9ff Compare September 2, 2026 22:50
@markcmiller86

Copy link
Copy Markdown
Member

I think this explains why I was seeing very long query times in the queries I added to test degenerate hex logic in #20364. I noticed the new queries I added took ~5 mins and should have taken only a second.

Thanks for fixing 💪.

@biagas
biagas force-pushed the bugfix/biagas/node_pick_degen_hexes branch from 0add9ff to a02fd49 Compare September 14, 2026 16:32
@biagas

biagas commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

I think this explains why I was seeing very long query times in the queries I added to test degenerate hex logic in #20364. I noticed the new queries I added took ~5 mins and should have taken only a second.

Thanks for fixing 💪.

Am I missing something? I am only seeing a Volume query in your PR, I don't see how my changes would affect the speed of that query.

@markcmiller86

Copy link
Copy Markdown
Member

Am I missing something? I am only seeing a Volume query in your PR, I don't see how my changes would affect the speed of that query.

Hmm...no...maybe I am missing something 😉. But, now that we're clear about the differences, perhaps it is worth a look at those queries too as they take way too long given what I know about what it should really take.

Added vtkVisItUtility::EvaluatePosition, which has a fallback for degnerate cells when vtkCell::EvaluatePosition fails.
Updated calls to vtkCell::EvaluatePosition to use the new method where necessary.
Fixed an bit of logic using integer division when it should have been double. It was causing picks to bog down and take quite awhile to return results.
45 seconds for a pick now down to 0.006 in testing.
@biagas
biagas force-pushed the bugfix/biagas/node_pick_degen_hexes branch from a02fd49 to 94ca263 Compare September 15, 2026 18:06
@biagas
biagas marked this pull request as ready for review September 15, 2026 18:06
@biagas
biagas merged commit c776d85 into develop Sep 16, 2026
4 checks passed
@biagas
biagas deleted the bugfix/biagas/node_pick_degen_hexes branch September 16, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node pick failing for mesh with degenerate hexes

3 participants