Update Conduit to 0.9.8 - #21144
Merged
JustinPrivitera merged 6 commits intoSep 4, 2026
Merged
Conversation
JustinPrivitera
marked this pull request as ready for review
September 3, 2026 23:36
JustinPrivitera
marked this pull request as draft
September 3, 2026 23:40
Member
Author
|
Looks like there is an issue with a blueprint specset test. I will investigate. |
Contributor
shall I await results on this before review? |
Member
Author
I think so. There may be code changes involved. I am trying to determine now if the issue is from Conduit or from VisIt. |
Member
Author
|
Looks like datatype changes in the results from |
JustinPrivitera
marked this pull request as ready for review
September 4, 2026 04:03
Member
Author
|
@biagas should be ready for review, all issues addressed. Thanks for your patience! |
biagas
approved these changes
Sep 4, 2026
JustinPrivitera
deleted the
task/JustinPrivitera/09_03_26/update_conduit_to_0.9.8
branch
September 4, 2026 19:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #21074
Updates Conduit to 0.9.8.
Fixes type conversion issue. This issue came to light because I reworked
to_siloinside of Conduit. I changed some of the integer data types there and the code in VisIt depended on the integer types being 32 bit ints instead of 64 bit. I fixed this so they can handle all integer cases.Type of change
[ ] Bug fix[ ] New feature[ ] Documentation updateTPL update
How Has This Been Tested?
Built VisIt and all TPLs on RZWhippet.
Blueprint tests pass.
Reminders:
Checklist:
[ ] I have made corresponding changes to the documentation.[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.