Las1.4 support with all point formats#37
Conversation
* Add all LasPoint types * Added tests * Added github actions for CI/CD * Added laszip connection * Updated Readme.md * reset github actions * PR changes
|
Just a quick note:
It seems @evetion has made https://github.com/evetion/LazIO.jl for laz support, so presumably you should use that for laz integration. (For laszip libraries see the build recipe at JuliaPackaging/Yggdrasil#1079) |
1c9476c to
c69e05f
Compare
c69e05f to
71a2641
Compare
I initially did attemp to integrate all this with LazIO. However, very quickly, it got a little too complicated for me. Also, when I read the raw LasPoint6 data using LazIO, I was getting weird data errors (return number was > number of return). Obviously I was doing something wrong there. I found working with executable extremely simple so I complemented the, already existing, LAZ functionality of LasIO instead. Gave the cleanest looking code. I did want to ask, why don’t we add a |
I think it would be good to add this. It may be as simple as adding an |
Feel free to make an issue over at LazIO for such things. Could be bugs in
I agree with adding Overall, we're very happy with PRs, but I would advise to coordinate a bit more in the future, so we can better help you. For example, there's an defunct PR over at #16 (itself based on work by @c42f), that could provide some inspiration, as it also includes some waveform parts and extended vlrs. |
Which is used to pipe Laz files in LasIO.jl, and is needed for visr/LasIO.jl#37
This PR enables reading and writing of Las files version 1.4 and all PointFormats 0 - 10.
Still TODOs:
Thank you for your time and feedback in advance!