fix: keep repeated config resolution idempotent - #23208
Open
teamleaderleo wants to merge 4 commits into
Open
Conversation
btea
previously approved these changes
Aug 9, 2026
bluwy
reviewed
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What’s happening?
Calling
resolveConfig()more than once with the same inline config can duplicate options added to an environment during the previous resolution.For example, an inline config containing one optimizer plugin currently produces:
We encountered this during a server restart, where the duplicated plugin changed the dependency optimizer config hash and caused an otherwise warm cache to be rebuilt.
The first resolution adds the resolved client environment to the inline config. When that same config is resolved again, the top-level optimizer options are merged into the existing client environment a second time, concatenating the plugin arrays.
What changes?
This change creates a shallow copy of the config and its existing environment objects before Vite applies resolver-generated environment defaults.
The resolved environment state therefore stays local to that resolution instead of affecting a later call with the same inline config.
Tests
Added a regression that resolves the same inline config twice and verifies that both results contain one optimizer plugin.