Skip to content

fix(define): fix match escaped dots to support $-prefixed define keys #23249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluwy merged 1 commit into from
Aug 13, 2026
+10 −1
Merged

fix(define): fix match escaped dots to support $-prefixed define keys #23249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/vite/src/node/__tests__/plugins/define.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,15 @@ describe('definePlugin (SSR dev)', () => {
).toBe(undefined)
})

test('replaces define keys containing `$`', async () => {
const transform = await createJsDefinePluginTransform({
$FOO: JSON.stringify('bar'),
})
expect(await transform('export const x = $FOO;')).toBe(
'export const x = "bar";\n',
)
})

test('replace import.meta.env when it is a invalid json', async () => {
const transform = await createJsDefinePluginTransform({
'import.meta.env.LEGACY': '__VITE_IS_LEGACY__',
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/define.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { isHTMLRequest } from './html'

const nonJsRe = /\.json(?:$|\?)/
const isNonJsRequest = (request: string): boolean => nonJsRe.test(request)
const escapedDotRE = /(?<!\\)\\./g
const escapedDotRE = /(?<!\\)\\\./g

export function definePlugin(config: ResolvedConfig): Plugin {
const isBuild = config.command === 'build'
Expand Down
Loading