fix(asset): preserve IPv6 brackets in server origin for url imports - #23354
Closed
vaibhavmashal wants to merge 1 commit into
Closed
fix(asset): preserve IPv6 brackets in server origin for url imports#23354vaibhavmashal wants to merge 1 commit into
vaibhavmashal wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
bot: likely
Contributor
|
This PR has been automatically flagged as likely to be created by a bot, LLM, or agent, and will be automatically closed. These contributions harm the maintenance of the project. Please read our AI policy for more information. If you believe this is a mistake, please reply to this comment and we will review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an IPv6 address for the server origin (like \http://[::1]), the \encodeURIPath\ function incorrectly encodes the square brackets into %5B\ and %5D. This causes issues with ?url\ imports that rely on the origin being valid. This PR restores the brackets in the origin host section after encoding.