fix(ssr): throw on missing named exports in inlined modules - #23359
Closed
bun-unsafe wants to merge 1 commit into
Closed
fix(ssr): throw on missing named exports in inlined modules#23359bun-unsafe wants to merge 1 commit into
bun-unsafe wants to merge 1 commit into
Conversation
Vite-transformed SSR modules skipped analyzeImportedModDifference, so import { missing } from a local ESM file succeeded while Node throws SyntaxError. Run the same check after the module finishes evaluating, and skip it on incomplete circular graphs.
Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
the
bot: likely
Contributor
|
This PR has been automatically flagged as likely to be created by a bot, LLM, or agent, and will be automatically closed. These contributions harm the maintenance of the project. Please read our AI policy for more information. If you believe this is a mistake, please reply to this comment and we will review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ssrLoadModule/runner.import) skippedanalyzeImportedModDifference.import { missing } from './file.js'therefore succeeded, while Node throwsSyntaxError.moduleas the type (inlined fetch results have notype).exportsobject before evaluation finishes. Named-export checks run only after the module is complete, so existing cycle fixtures keep working.Test plan
vitest run packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts packages/vite/src/node/ssr/__tests__/ssrLoadModule.spec.tstest-uniton this PR