Repository navigation
feat: add environment.addSafeModule - #23974
Open
sapphi-red wants to merge 2 commits into
Open
sapphi-red wants to merge 2 commits into
sapphi-red wants to merge 2 commits into
Conversation
sapphi-red
force-pushed
the
feat/add-environment-addSafeModule
branch
from
November 2, 2026 06:15
ace68ef to
e50683f
Compare
sapphi-red
added
p2-nice-to-have
sapphi-red
marked this pull request as ready for review
November 2, 2026 06:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
environment.addSafeModuleso that plugins can allow modules that are referenced in source code but is not detected by import analysis.This helps will make users not have to add the modules to
server.fs.alloweven if #23972 is enabled.Stack created with GitHub Stacks CLI • Give Feedback 💬