Repository navigation
fix(hmr): preserve environment snapshot during server restart (#22992) - #23987
Open
jasleenkaur-qed42 wants to merge 1 commit into
Open
jasleenkaur-qed42 wants to merge 1 commit into
jasleenkaur-qed42 wants to merge 1 commit into
Conversation
✅ Deploy Preview for vite-docs-v7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #22992 to v7.
Saving the config file while another file's HMR update is still in flight (its
hotUpdate/handleHotUpdatehooks are being awaited) crashes the dev server withTypeError: Cannot set properties of undefined (setting 'error').Root Cause
handleHMRUpdatekeyshotMapby the environment instances present at the start of the update. A config-change restart replacesserver.environmentsin place, so after the awaited hook the handler looks up environments that were never added tohotMap, and the catch block writes.erroronundefined.Changes
Testing
pnpm exec vitest run packages/vite/src/node/server/__tests__/hmr.spec.ts: fails without the change, passes with itpnpm run test-unit, HMR playground e2e, typecheck, lintRelated Issue
Closes #23984