ci(macos): update Homebrew and smoke-test spell-check backend - #2948
Open
markiehill wants to merge 1 commit into
Open
ci(macos): update Homebrew and smoke-test spell-check backend#2948markiehill wants to merge 1 commit into
markiehill wants to merge 1 commit into
Conversation
Fix the macOS spell-check regression (vkbo#2705) that persisted even after bundling only the applespell backend: on a clean machine the dictionary dropdown was still empty, regardless of the user's OS language. Root cause: the macos-14 runner image pins a stale Homebrew snapshot with auto-update disabled, so `brew install enchant` poured enchant 2.8.16. Its AppleSpell provider uses a hard-wired language list that resolves to an empty dictionary set on current macOS. enchant 2.8.18 dropped the hard-wired list and reports the actual system dictionaries, so the shipped DMG needs enchant >= 2.8.18. - Run `brew update` before installing so the fixed enchant bottle is used. - Add a runtime smoke test: load the bundled libenchant exactly as the frozen app does (via PYENCHANT_LIBRARY_PATH) and assert it yields working dictionaries served by the bundled backend. A backend file can be present yet expose zero dictionaries, which the previous presence-only guard could not detect, so a broken backend now fails the build instead of shipping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: dfbf93cc-170a-4853-be97-161aa477883e
Owner
|
Thanks! Could you trim down the massive blocks of AI-generated comments please? There's just too much of it. |
Owner
|
This branch also needs to be rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the macOS spell-check regression (#2705) that persisted even after bundling only the applespell backend: on a clean machine the dictionary dropdown was still empty, regardless of the user's OS language.
Root cause: the macos-14 runner image pins a stale Homebrew snapshot with auto-update disabled, so
brew install enchantpoured enchant 2.8.16. Its AppleSpell provider uses a hard-wired language list that resolves to an empty dictionary set on current macOS. enchant 2.8.18 dropped the hard-wired list and reports the actual system dictionaries, so the shipped DMG needs enchant >= 2.8.18.brew updatebefore installing so the fixed enchant bottle is used.Summary:
Related Issue(s):
Reviewer's Checklist: