Skip to content

Update MiniMax M3 MXFP4 AITER command#609

Open
haic0 wants to merge 1 commit into
vllm-project:mainfrom
haic0:haic0/update-minimax-m3-mxfp4-aiter-command
Open

Update MiniMax M3 MXFP4 AITER command#609
haic0 wants to merge 1 commit into
vllm-project:mainfrom
haic0:haic0/update-minimax-m3-mxfp4-aiter-command

Conversation

@haic0

@haic0 haic0 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Refresh the MI355X MXFP4 guide command to use the ROCm AITER MoE path and text-only launch flags.

Refresh the MI355X MXFP4 guide command to use the ROCm AITER MoE path and text-only launch flags.

Signed-off-by: haic0 <haichzha@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vllm-recipes Ready Ready Preview, Comment Jul 3, 2026 3:17am

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vllm serve guide command for the MiniMax-M3 model to use ROCm AITER MoE paths, text-only launch flags, and associated environment variables, while removing the multimodal encoder arguments. The review feedback highlights two main issues: first, the $MAX_MODEL_LEN environment variable is used in the command but not defined in the snippet; second, the mxfp4 variant hardware overrides still contain the old multimodal encoder arguments and lack the new environment variables and arguments, which should be updated to maintain consistency.

Comment on lines +459 to +461
export VLLM_ROCM_USE_AITER=1
export VLLM_ROCM_USE_AITER_MOE=1
export VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The command uses the $MAX_MODEL_LEN environment variable on line 469, but it is not defined or initialized anywhere in this bash snippet. If a user copy-pastes and runs this block directly, the variable will evaluate to an empty string, causing the vllm serve command to fail with a parsing error.

Please define MAX_MODEL_LEN in the environment setup lines above the command.

  export VLLM_ROCM_USE_AITER=1
  export VLLM_ROCM_USE_AITER_MOE=1
  export VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS=1
  export MAX_MODEL_LEN=131072

Comment on lines +467 to +471
--no-enable-prefix-caching \
--language-model-only \
--max-model-len "$MAX_MODEL_LEN" \
--attention-backend TRITON_ATTN \
--mm-encoder-tp-mode data \
--mm-encoder-attn-backend ROCM_AITER_FA \
--moe-backend aiter \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The updated guide command now uses the text-only launch flags (--language-model-only, --no-enable-prefix-caching) and the ROCm AITER MoE path (--moe-backend aiter), and removes the multimodal encoder flags (--mm-encoder-tp-mode data, --mm-encoder-attn-backend ROCM_AITER_FA).

However, the mxfp4 variant definition under variants.mxfp4.hardware_overrides.mi355x (lines 123-132) still contains the old multimodal encoder arguments and lacks the new environment variables and arguments:

    hardware_overrides:
      mi355x:
        docker_image: "vllm/vllm-openai-rocm:nightly"
        extra_args:
          - "--trust-remote-code"
          # Keep the multimodal encoder loaded and run it data-parallel on MI355X.
          - "--mm-encoder-tp-mode"
          - "data"
          - "--mm-encoder-attn-backend"
          - "ROCM_AITER_FA"

To ensure that the automated command builder/UI generates the correct command for the mxfp4 variant, please update the variant definition in lines 123-132 to match the new guide command:

    hardware_overrides:
      mi355x:
        docker_image: "vllm/vllm-openai-rocm:nightly"
        extra_args:
          - "--trust-remote-code"
          - "--no-enable-prefix-caching"
          - "--language-model-only"
          - "--moe-backend"
          - "aiter"
        extra_env:
          VLLM_ROCM_USE_AITER: "1"
          VLLM_ROCM_USE_AITER_MOE: "1"
          VLLM_ROCM_USE_AITER_FUSION_SHARED_EXPERTS: "1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants