Repository navigation
vapi/library: add SslCertificate to Subscription - #4143
Conversation
🛑 Legal Compliance Check FailedHi @ericvmw, thank you for your contribution! To merge this Pull Request, you must sign our DCO. Note: Even if you signed off your commits locally (using 1. Read the Document: Click here to read the DCO ⏳ Processing Schedule: |
96a931b to
94946ec
Compare
|
I have read the DCO Document and I hereby sign the DCO for this and all future contributions. |
Add the optional ssl_certificate field to the library Subscription spec. Fixes: vmware#4142 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Eric Cao <eric.cao@broadcom.com>
Skip the automatic SslThumbprint lookup when SslCertificate is set. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Eric Cao <eric.cao@broadcom.com>
UpdateLibrary now sends the Subscription for SUBSCRIBED libraries via the subscribed-library endpoint, allowing the subscription URL, SSL certificate, etc. to be changed. The simulator patches the subscription. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Eric Cao <eric.cao@broadcom.com>
f376892 to
846f37a
Compare
zach96guan
left a comment
zach96guan
left a comment
There was a problem hiding this comment.
LGTM!
(Weird.. seems I don't have access to approve the govmomi PR)
3 participants
Add the optional
ssl_certificatefield to the content librarySubscriptionspec, matchingSubscriptionInfo.sslCertificate, and support updating the subscription of a subscribed library viaUpdateLibrary(subscription URL, SSL certificate, etc.).Includes unit tests for the new field and for updating a subscribed library.
Fixes: #4142
🤖 Generated with Claude Code