Skip to content

Upgrade k8s modules and linter - #3269

Merged
cfryanr merged 13 commits into
mainfrom
upgrade-k8s-mods-and-linter
Oct 5, 2026
Merged

cfryanr merged 13 commits into
mainfrom
upgrade-k8s-mods-and-linter

Conversation

@cfryanr

@cfryanr cfryanr commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

This PR:

  • Upgrades all go.mod dependencies. Most notably, it upgrades the k8s modules to v0.37.1.
  • Removes the generated code for k8s 1.31, which is now so old that it is 1 year beyond support.
  • Adds the generated code for k8s 1.37.
  • Upgrades golangci-lint to v2.13.1 and fixes all resulting warnings.
  • Fixes some test expectations and also fix the production code in impersonator.go to make them compatible with both Go 1.27 and also with older versions, e.g. Go 1.26. With these changes, all unit tests pass when run with either Go 1.26 or Go 1.27.

Note to reviewers: Because this PR includes generated code, it will probably be easier to review each commit separately. The generated code shouldn't need human review since it is auto-generated.

Release note:

NONE

cfryanr and others added 5 commits August 27, 2026 14:48
Signed-off-by: Ryan Richard <richardry@vmware.com>
Signed-off-by: Ryan Richard <richardry@vmware.com>
Signed-off-by: Ryan Richard <richardry@vmware.com>
Signed-off-by: Ryan Richard <richardry@vmware.com>
@netlify

netlify Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for pinniped-dev canceled.

Name Link
🔨 Latest commit 9b42724
🔍 Latest deploy log https://app.netlify.com/projects/pinniped-dev/deploys/6ac413135e3475000816b0cb

@aabusair aabusair closed this Aug 28, 2026
@aabusair aabusair reopened this Aug 28, 2026
Fix some test expectations and also fix the production code in
impersonator.go to make them compatible with both Go 1.27 and also
with older versions, e.g. Go 1.26. With these changes, all unit
tests pass when run with either Go 1.26 or Go 1.27.

Signed-off-by: Ryan Richard <richardry@vmware.com>

@v0lkan v0lkan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

v0lkan and others added 7 commits October 1, 2026 12:04
Subject-verb agreement on an error message.

Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
Golang version bump to 1.27.1 in Dockeerfile and Dockerfile_fips

Add `./anchor` to `.gitignore`.

Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
Signed-off-by: Ryan Richard <richardry@vmware.com>
Signed-off-by: Ryan Richard <richardry@vmware.com>
Signed-off-by: Ryan Richard <richardry@vmware.com>
@cfryanr
cfryanr merged commit cc975f2 into main Oct 5, 2026
40 checks passed
@cfryanr
cfryanr deleted the upgrade-k8s-mods-and-linter branch October 5, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants