fix: address documentation and tooling drift (#163) - #166
Conversation
- README and getting-started: dev deps moved to a uv dependency group, so `pip install -e '.[dev]'` no longer works. Point at `make install` (which runs `uv sync` + pre-commit install) and reference CONTRIBUTING for the full workflow. - mkdocs nav: add `custom-images.md` under User Guide so it stops appearing as an unlinked page. - container-pooling.md: API Reference links now resolve to real mkdocstrings anchors. Adds the matching `:::` directives for `pool.base.ContainerPoolManager`, `pool.config.PoolConfig`, `pool.session.PooledSandboxSession`, and `pool.factory.create_pool_manager` to docs/api-reference.md. - container-pooling.md: replace dangling `configuration.md#performance-optimization` link with the real `#container-pooling-configuration` anchor. `uv run mkdocs build -s` now reports zero warnings (was 6, all fatal under `-s`). Docs CI in `main.yml` already invokes `mkdocs build -s`, so future drift will fail the build.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis pull request resolves documentation and tooling drift by updating development setup instructions across README and docs to reflect the ChangesDocumentation and Tooling Alignment
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Checked both claims and they hold.
The pooling anchors are genuinely missing too. I'd seen those scroll past and not chased them. Good catch. Small and correct — merging this one. |



Closes #163.
1. README + docs dev-install command
pip install -e '.[dev]'stopped working when dev deps moved from[project.optional-dependencies]into thedevuv dependency group (currentpyproject.toml). BothREADME.mdanddocs/getting-started.mdnow point atmake install, which is whatCONTRIBUTING.mdand theMakefilealready canonicalize to (uv sync+pre-commit install).docs/mcp-integration.mdstill usespip install -e '.[mcp-docker]'— left alone becausemcp-dockeris a real[project.optional-dependencies]extra, so that command still works.2.
custom-images.mdin navAdded under User Guide between Container Backends and Supported Languages. The file already has substantive content covering custom images, Dockerfiles, and pre-installed libraries, so merging into another page would have lost structure. One-line change in
mkdocs.yml.3.
container-pooling.mdstale anchorsTwo distinct issues:
api-reference.md#llm_sandbox.pool.{base.ContainerPoolManager,config.PoolConfig,session.PooledSandboxSession,factory.create_pool_manager}, butdocs/api-reference.mdhad no:::directives for those modules — anchors never existed. Added a Container Pooling section toapi-reference.mdwith the four mkdocstrings entries; anchors now resolve.configuration.md#performance-optimization, which doesn't exist. Repointed atconfiguration.md#container-pooling-configuration(real anchor, more relevant to the link text anyway).4. Fail CI on doc warnings
Already done —
.github/workflows/main.ymlcheck-docsjob runsuv run mkdocs build -sandMakefileexposes the same asmake docs-test. No workflow changes needed.5.
mkdocs build -swarning countmkdocs build -swarningsSix pre-existing INFO-level drift messages (1 unlisted nav page + 5 unresolved anchor links from
container-pooling.md) — all gone:Diffstat
Did not touch
docs/security.md(recently rewritten in #165).Summary by CodeRabbit
Documentation
uvandmake installinstead of pip.