fix: add position:relative to .interactive-session for dnd overlay#956
Open
octo-patch wants to merge 1 commit intovoideditor:mainfrom
Open
fix: add position:relative to .interactive-session for dnd overlay#956octo-patch wants to merge 1 commit intovoideditor:mainfrom
octo-patch wants to merge 1 commit intovoideditor:mainfrom
Conversation
…ixes voideditor#925) The .chat-dnd-overlay element uses position:absolute to cover the chat panel during drag-and-drop, but its parent .interactive-session lacked a positioning context (position:relative). This caused the overlay to be positioned relative to a wrong ancestor, making it appear off-screen or in an incorrect location with no visual feedback during drag operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #925
Problem
Dragging files from the Explorer to the Chat panel does not show the blue drop overlay. The
.chat-dnd-overlayelement usesposition: absoluteto cover the chat session container, but its parent.interactive-sessionwas missingposition: relative. Without a positioning context on the parent, the absolutely-positioned overlay is anchored to a wrong ancestor element (e.g., the viewport), causing it to render off-screen with no visible feedback during drag operations.Solution
Add
position: relativeto.interactive-sessioninchat.css. This provides the correct positioning context so.chat-dnd-overlayis sized and positioned relative to the chat panel rather than a distant ancestor.Testing
chatDragAndDrop.tsis unchanged; this is a one-line CSS-only fixposition: relativewithout explicittop/left/width/heighthas no visual side effects on the container itself