fix release npm compatibility#2190
Merged
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
wan9chi
commented
Jul 16, 2026
wan9chi
left a comment
wan9chi
left a comment
Member
Author
There was a problem hiding this comment.
Context on the manual release trigger.
wan9chi
marked this pull request as ready for review
July 16, 2026 23:49
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cab49bfc69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cpojer
approved these changes
Jul 17, 2026
cpojer
left a comment
cpojer
left a comment
Member
There was a problem hiding this comment.
Alright, but please remove that again after the release is published.
wan9chi
added a commit
that referenced
this pull request
Jul 17, 2026
## Why [v0.2.5](https://github.com/voidzero-dev/vite-plus/releases/tag/v0.2.5) has been published successfully by [Release run 29545637687](https://github.com/voidzero-dev/vite-plus/actions/runs/29545637687). PR #2190 added a temporary manual trigger to retry the unpublished release after fixing the npm/Node compatibility failure. ## Changes - remove the temporary `workflow_dispatch` trigger - remove the now-redundant `main` ref guard; the remaining push trigger already only accepts `main`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v0.2.5 release run failed before publishing because
npm@latestresolved to npm 12.0.1. npm 12.0.1 requires Node 22.22.2 or newer, while the workflow used Node 22.18.0.Changes
workflow_dispatchso the corrected v0.2.5 release can be started manually