fix(global): keep the installed version spec on global update - #2249
fix(global): keep the installed version spec on global update#2249TheAlexLichter wants to merge 5 commits into
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Staging deployment successful! Preview: https://viteplus-staging.void.app/ |
44cccc1 to
2776009
Compare
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.31 MiB | 10.33 MiB | +24.00 KiB (+0.23%) |
vp (Linux x64) |
gzip -9 | 4.42 MiB | 4.43 MiB | +9.75 KiB (+0.22%) |
| NAPI (Linux x64) | Binary | 33.07 MiB | 33.07 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.72 MiB | 12.72 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 7.64 MiB | 7.65 MiB | +16.16 KiB (+0.21%) |
vp (macOS ARM64) |
gzip -9 | 3.84 MiB | 3.85 MiB | +12.83 KiB (+0.33%) |
| NAPI (macOS ARM64) | Binary | 40.50 MiB | 40.50 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.97 MiB | 16.97 MiB | -11 B (-0.00%) |
vp (Windows x64) |
Binary | 8.35 MiB | 8.37 MiB | +25.50 KiB (+0.30%) |
vp (Windows x64) |
gzip -9 | 3.64 MiB | 3.65 MiB | +13.41 KiB (+0.36%) |
| NAPI (Windows x64) | Binary | 27.51 MiB | 27.51 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.70 MiB | 10.70 MiB | +13 B (+0.00%) |
| Trampoline (Windows x64) | Binary | 203.00 KiB | 203.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 97.91 KiB | 97.91 KiB | +1 B (+0.00%) |
| Installer (Windows x64) | Binary | 4.44 MiB | 4.44 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.08 MiB | 2.08 MiB | 0 B (0.00%) |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2776009380
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
|
@TheAlexLichter Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
2 similar comments
|
@TheAlexLichter Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@TheAlexLichter Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
Codex noooo |
oh, what happened? |
3 participants
Resolves #2247
At the moment, when
vpinstalls global packages from a dist-tag or range (for examplevp i pkg@nightly -g) it only records the resolved version, not the actual tag or range.That means,
vp up -g(re-)resolved every package againstlatest, silently replacing a tag likenightlywith an older stable release.This PR causes that global installs now record the version spec, and update/outdated resolve within it, meaning tags follow their channel, ranges stay in range, pins hold.
vp outdated -greports Wanted vs Latest and warns if there is an unresolvable spec (e.g. a deleted dist tag).vp update -g --latestexplicitly moves packages back tolatestand clears the recorded specs.