Skip to content

Run Codegen Check for all pull requests#411

Merged
volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
safiya2610:fix/codegen-check-workflow
Jul 2, 2026
Merged

Run Codegen Check for all pull requests#411
volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
safiya2610:fix/codegen-check-workflow

Conversation

@safiya2610

@safiya2610 safiya2610 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

This PR removes path-based filtering from the Codegen Check workflow so that make gen-check runs for every pull request.

Motivation
Previously, Codegen Check could be skipped when changes did not match the configured path filters. As a result, changes to files such as go.mod and go.sum could bypass the workflow, allowing code generation inconsistencies to remain undetected until a later pull request.

Running the workflow unconditionally ensures that generated code and dependency-related inconsistencies are detected immediately, improving CI reliability.

Changes
Removed path-based filtering from the Codegen Check workflow.
Configured make gen-check to run for every pull request targeting main and release-*.

Fixes #401

Copilot AI review requested due to automatic review settings June 28, 2026 14:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused dependency entries for golang.org/x/oauth2 v0.36.0 from the go.sum file. I have no feedback to provide as there are no review comments or issues identified.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI “Codegen Check” workflow so make gen-check runs for every pull request targeting main and release-*, instead of being skipped via path-based filtering. This helps catch generated-code and dependency consistency issues (e.g., go.mod / go.sum changes) immediately.

Changes:

  • Removed dorny/paths-filter gating from the Codegen Check workflow.
  • Made Go setup and make gen-check execute unconditionally for PRs into main and release-*.
  • Updated go.sum to drop now-unneeded golang.org/x/oauth2 v0.36.0 entries.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.sum Removes stale module checksum entries so module state matches actual requirements.
.github/workflows/codegen-check.yml Ensures make gen-check runs on every PR to main / release-* by removing path-based filtering.

@codecov-commenter

codecov-commenter commented Jun 28, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.47%. Comparing base (524e55e) to head (b98ce7a).
⚠️ Report is 150 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #411       +/-   ##
===========================================
+ Coverage   47.57%   58.47%   +10.90%     
===========================================
  Files          30       36        +6     
  Lines        2819     3463      +644     
===========================================
+ Hits         1341     2025      +684     
+ Misses       1338     1230      -108     
- Partials      140      208       +68     
Flag Coverage Δ
unittests 58.47% <ø> (+10.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@safiya2610

Copy link
Copy Markdown
Contributor Author

@zhzhuang-zju Please review this PR.

@safiya2610

Copy link
Copy Markdown
Contributor Author

/cc @RainbowMango
/cc @hzxuzhonghu

@zhzhuang-zju

Copy link
Copy Markdown
Contributor

Hi @safiya2610, #399 has been merged, you can rebase and push again

@safiya2610 safiya2610 force-pushed the fix/codegen-check-workflow branch from 5ca694e to 77163f8 Compare July 2, 2026 04:00
@safiya2610 safiya2610 force-pushed the fix/codegen-check-workflow branch 2 times, most recently from 63b0c50 to 17888d5 Compare July 2, 2026 04:25
Copilot AI review requested due to automatic review settings July 2, 2026 04:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

@safiya2610

Copy link
Copy Markdown
Contributor Author

Hi @safiya2610, #399 has been merged, you can rebase and push again

done @zhzhuang-zju

Comment thread go.sum
Comment on lines 249 to 250

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@safiya2610, #399 has already removed these two lines, so no need to duplicate the operation.

BTW, I'm not sure why it wasn't detected as a conflict.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the rebase onto origin/main, Git detected that the go.sum changes had already been applied upstream, so it considered them already integrated and did not report a merge conflict.

@safiya2610 safiya2610 Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhzhuang-zju So now I removed the duplicate operation too, you can check.

@safiya2610 safiya2610 force-pushed the fix/codegen-check-workflow branch from 7f7b13a to cf133e4 Compare July 2, 2026 06:29
Copilot AI review requested due to automatic review settings July 2, 2026 06:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

Signed-off-by: Safiya <147792763+safiya2610@users.noreply.github.com>
@zhzhuang-zju

Copy link
Copy Markdown
Contributor

Thanks, LGTM
/cc @RainbowMango

@RainbowMango RainbowMango left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit f9c37d5 into volcano-sh:main Jul 2, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Codegen Check path filter causes false pass

6 participants