fix(nodeorder): log correct plugin weight in NodeOrderFn#5510
fix(nodeorder): log correct plugin weight in NodeOrderFn#5510A69SHUBHAM wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects a logging statement in the NodeOrderPlugin by replacing the incorrect reference pp.weight.imageLocalityWeight with p.weight to match the actual weight variable used in the score calculation. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
This PR fixes misleading V(5) debug logging in the nodeorder scheduler plugin so that the logged weight matches the actual per-score-plugin weight (p.weight) used in the score calculation.
Changes:
- Update
NodeOrderFn()debug log to print the current score plugin’s configured weight (p.weight) instead of always printingimageLocalityWeight.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -323,7 +323,7 @@ func (pp *NodeOrderPlugin) NodeOrderFn(task *api.TaskInfo, node *api.NodeInfo, k | |||
|
|
|||
| // If imageLocalityWeight is provided, host.Score is multiplied with weight, if not, host.Score is added to total score. | |||
Signed-off-by: A69SHUBHAM <spacekrai0@gmail.com>
A69SHUBHAM
force-pushed
the
fix-nodeorder-log-weight
branch
from
5bd6b5b to
a5b4b36
Compare
|
/cc @hajnalmt Would appreciate a review when you have time. Thanks! |
What this PR does
The debug log inside
NodeOrderFn()reportsimageLocalityWeightfor every score plugin, even though the scheduler computes the score using each plugin's own configured weight (p.weight).This PR updates the debug log to report the actual plugin weight used during score calculation, making V(5) scheduler logs consistent with the scheduler's behavior.
Why is this change needed?
When multiple score plugins are configured with different weights, the current debug output can be misleading during troubleshooting because it always reports the ImageLocality weight regardless of which plugin generated the score.
Does this PR introduce any user-facing changes?
No.
This change only corrects debug logging and does not affect scheduler behavior or score calculation.
Fixes #5509