Feat/自进化(经验记忆)框架重构#2503
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
qin-ctx
left a comment
There was a problem hiding this comment.
这次 review 只发布 inline findings。结论:REQUEST_CHANGES。前三条是 blocking,后面三条是 non-blocking,但都建议在这个大 PR 合入前处理或明确取舍。
qin-ctx
left a comment
There was a problem hiding this comment.
这次 review 结论是 REQUEST_CHANGES。
整体方向是合理的:V3 把抽取、patch merge、训练和 rollout 拆开,并通过 streaming batch 降低锁粒度;之前几条历史 blocking 评论我也重新核过,大多已经修掉。
历史评论追踪:
- locomo import 的 canonical sample id 问题已修,并补了覆盖 peer wiring 的测试。
- patch merge hidden fields 已补
last_update_trace_id。 - case 到 experience 的 root uri fallback 已改为显式报错。
- no-op merge fast path 已改为比较 render 后内容。
memory.version现在代码和文档都说明已废弃且强制 v3;建议 PR 模板里补上变更类型和测试说明。
我在 PR 快照上跑了 python -m compileall -q openviking benchmark/locomo/vikingbot benchmark/tau2 bot/vikingbot tests/session tests/unit tests/integration,没有语法错误。
需要先修已发出的两条 inline 问题,尤其是 batch result 泄漏到单个 session archive 的阻塞问题。
qin-ctx
left a comment
There was a problem hiding this comment.
本次只发布必须修复项:
- streaming memory updater 的 batch aggregate result 仍未按 submitter/session 隔离,可能导致跨 session 的 memory diff/context/case 串写。
- remote rollout 的 policy_set metadata 会携带 OpenViking API key,存在凭证外泄风险。
建议修复后再合入。
qin-ctx
left a comment
There was a problem hiding this comment.
发现 1 个 blocking 问题:case 训练输入在 patch merge 前固定,可能和最终落库的 canonical case 不一致。
* fix(server): restore identity resolution in /health endpoint The /health endpoint was refactored in #2503 which removed the identity resolution logic. This caused the frontend dashboard to show 'Usage/Audit 未初始化' because the role field was missing from the response. Restored the identity resolution so that /health returns account_id, user_id, and role when an API key is provided. Co-Authored-By: Claude <noreply@anthropic.com> * test(server): update health endpoint tests for identity resolution - Test that /health returns identity info when API key is provided - Test that /health omits identity info when no API key is provided Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: wugj <wugj@g-bits.com> Co-authored-by: Claude <noreply@anthropic.com>
Description
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes