Skip to content

claashk: unified_api_buffering#704

Open
r00t- wants to merge 5 commits into
volkszaehler:masterfrom
claashk:unified_api_buffering
Open

claashk: unified_api_buffering#704
r00t- wants to merge 5 commits into
volkszaehler:masterfrom
claashk:unified_api_buffering

Conversation

@r00t-

@r00t- r00t- commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

I implemented a joint buffer for these two APIs, which I am currently testing in my local home environment. Would you be interested in a PR?
-- #694 (comment)

@claashk: thanks for the offer, i'll have a look

@r00t- r00t- changed the title vzlogger:unified_api_buffering claashk: unified_api_buffering Apr 23, 2026
@r00t- r00t- mentioned this pull request Apr 23, 2026
@isarrider

Copy link
Copy Markdown
Contributor

@claashk also with this PR it seems to not work (with VictoriaMetrics):

image

@isarrider

Copy link
Copy Markdown
Contributor

the only thing that I could think of right now is that VictoriaMetrics doenst like the format batch inserts come (VictoriaMetrics/VictoriaMetrics#75 & https://valyala.medium.com/measuring-vertical-scalability-for-time-series-databases-in-google-cloud-92550d78d8ae), but it seems it doesnt even get them...

@isarrider

Copy link
Copy Markdown
Contributor

_vzlogger_logs.txt
the build is the latest in your repo:
claashk@d51cc3d

@r00t-

r00t- commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

seems to not work with VictoriaMetrics

thanks for testing, but i was not aware that was a software we support, i suggest you re-test with influxdb, and/or create a separate ticket and not spam this MR, thanks.

@claashk

claashk commented May 2, 2026

Copy link
Copy Markdown
Contributor

@isarrider : Did you check out the unified_api_buffering branch?. Master is just tracking the vzlogger master.

@isarrider

Copy link
Copy Markdown
Contributor

@claashk Yes, I cloned it correctly - but then one has to build the Container from the right directory ;)
It works now - I get no interruption in the database, only sth like:
"InfluxDB response was cannot process influx line protocol data: incorrect influx line "0\nmeasurement,uuid=72f49 [...] 0fd1d5 value=0.000000 1777971560254\n": cannot find Whitespace I in "0"; see https://docs.victoriametrics.com/victoriametrics/in��tegrations/influxdb/"

but maybe thats Victoria-Metrics related... ([...] is not the actual text but just some placeholder)

@r00t-

r00t- commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

@isarrider:

It works now

so the issue you tried to report in your earlier comment was caused by running the wrong code and is resolved?

InfluxDB response was cannot process influx line protocol data: incorrect influx line "0\nmeasurement,uuid=72f49 [...] 0fd1d5 value=0.000000 1777971560254\n": cannot find Whitespace I in "0";

influxdb received a single ascii "0" on a line by itself: 0\n.
that is obviously not valid.
i don't see how the code in InfluxDB.cpp could have created such a line.
can you please increase the loglevel so that this debug print from line 306 is logged:
https://github.com/volkszaehler/vzlogger/pull/704/changes#diff-9e32a66171571cb43247af00f2833c8e231c33e7b5472e9c29c92d50c3c2d5aaR306

		print(log_finest, "request body is %s", channel()->name(), request_body);

and/or re-test with plain influxdb, so we don't need to guess if "victoria-metrics" added that "zero"-line.

@isarrider

Copy link
Copy Markdown
Contributor

I am busy atm with other things but will let you know when I did this test...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants