Skip to content

docs: fix stale Docker Desktop reference in shared-compile-cache.md - #461

Open
brbrainerd wants to merge 1 commit into
mainfrom
docs/fix-docker-desktop-refs
Open

docs: fix stale Docker Desktop reference in shared-compile-cache.md#461
brbrainerd wants to merge 1 commit into
mainfrom
docs/fix-docker-desktop-refs

Conversation

@brbrainerd

@brbrainerd brbrainerd commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up from PR #460: the CI runner fleet moved to the WSL2-native Docker Engine (Docker Desktop is not used on this host, per runner-autoscaling.md), but shared-compile-cache.md's MinIO restart-resilience note still referenced Docker Desktop specifically. Corrected, with a cross-reference to runner-autoscaling.md for the full context.

Audited all other "Docker Desktop" mentions under docs/src/ — the rest are already correct, legitimately historical (describing the pre-migration fleet), or unrelated citations of Docker Desktop as an external reference point, not claims about Vox's own tooling.

Test plan

  • Docs-only change, no code paths affected

Summary by CodeRabbit

  • Documentation
    • Clarified MinIO startup instructions for environments using the WSL2-native Docker Engine.
    • Documented that --restart always automatically handles Docker or WSL2 engine restarts.

The CI runner fleet moved to the WSL2-native Docker Engine (Docker Desktop
is not used on this host, per runner-autoscaling.md); this doc's MinIO
restart-resilience note still referenced Docker Desktop specifically.
Audited all other "Docker Desktop" mentions in docs/src/ — the rest are
either already correct (runner-autoscaling.md, alternatives-and-local-
mirroring.md already state WSL2-native explicitly), legitimately historical
(runner-autoscaling.md's "That setup had three failure modes" section
describing the old pre-migration fleet), or unrelated citations of Docker
Desktop as an external UX/portability reference point, not a claim about
Vox's own tooling (vox-gui-native-roadmap-2026.md, vox-portability-ssot.md).
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d8ebd85e-4f1e-489e-85a8-1291d9f0bad0

📥 Commits

Reviewing files that changed from the base of the PR and between 8644a32 and 98460fc.

📒 Files selected for processing (1)
  • docs/src/ci/shared-compile-cache.md

📝 Walkthrough

Walkthrough

Clarifies the shared compile cache startup instructions to describe Docker/WSL2 engine restarts and identify the host’s WSL2-native Docker Engine.

Changes

Compile cache documentation

Layer / File(s) Summary
Clarify engine restart instructions
docs/src/ci/shared-compile-cache.md
Updates the --restart always explanation to cover Docker/WSL2 engine restarts and notes that the host uses the WSL2-native Docker Engine.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: matahari13

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the documentation-only fix to a stale Docker Desktop reference in shared-compile-cache.md.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/fix-docker-desktop-refs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brbrainerd
brbrainerd enabled auto-merge July 22, 2026 13:37
@brbrainerd
brbrainerd added this pull request to the merge queue Jul 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 23, 2026
@brbrainerd
brbrainerd added this pull request to the merge queue Jul 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 23, 2026
@brbrainerd brbrainerd added fleet-down Self-hosted CI fleet outage — routes required gate to hosted fallback and removed fleet-down Self-hosted CI fleet outage — routes required gate to hosted fallback labels Aug 10, 2026
@brbrainerd brbrainerd added fleet-down Self-hosted CI fleet outage — routes required gate to hosted fallback and removed fleet-down Self-hosted CI fleet outage — routes required gate to hosted fallback labels Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleet-down Self-hosted CI fleet outage — routes required gate to hosted fallback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant