docs: fix stale Docker Desktop reference in shared-compile-cache.md - #461
Open
brbrainerd wants to merge 1 commit into
Open
docs: fix stale Docker Desktop reference in shared-compile-cache.md#461brbrainerd wants to merge 1 commit into
brbrainerd wants to merge 1 commit into
Conversation
The CI runner fleet moved to the WSL2-native Docker Engine (Docker Desktop is not used on this host, per runner-autoscaling.md); this doc's MinIO restart-resilience note still referenced Docker Desktop specifically. Audited all other "Docker Desktop" mentions in docs/src/ — the rest are either already correct (runner-autoscaling.md, alternatives-and-local- mirroring.md already state WSL2-native explicitly), legitimately historical (runner-autoscaling.md's "That setup had three failure modes" section describing the old pre-migration fleet), or unrelated citations of Docker Desktop as an external UX/portability reference point, not a claim about Vox's own tooling (vox-gui-native-roadmap-2026.md, vox-portability-ssot.md).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughClarifies the shared compile cache startup instructions to describe Docker/WSL2 engine restarts and identify the host’s WSL2-native Docker Engine. ChangesCompile cache documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brbrainerd
enabled auto-merge
July 22, 2026 13:37
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from PR #460: the CI runner fleet moved to the WSL2-native Docker Engine (Docker Desktop is not used on this host, per
runner-autoscaling.md), butshared-compile-cache.md's MinIO restart-resilience note still referenced Docker Desktop specifically. Corrected, with a cross-reference torunner-autoscaling.mdfor the full context.Audited all other "Docker Desktop" mentions under
docs/src/— the rest are already correct, legitimately historical (describing the pre-migration fleet), or unrelated citations of Docker Desktop as an external reference point, not claims about Vox's own tooling.Test plan
Summary by CodeRabbit
--restart alwaysautomatically handles Docker or WSL2 engine restarts.