fix: expose encrypt_password in Proxysql::User type alias - #255
Open
mailankitkm wants to merge 2 commits into
Open
fix: expose encrypt_password in Proxysql::User type alias#255mailankitkm wants to merge 2 commits into
mailankitkm wants to merge 2 commits into
Conversation
The proxy_mysql_user Ruby type already supports the encrypt_password parameter (lib/puppet/type/proxy_mysql_user.rb), which skips SHA1 hashing when set to false. However, the Proxysql::User Puppet type alias (types/user.pp) did not include it, causing Puppet catalog compilation to fail with "unrecognized key 'encrypt_password'" when the parameter was set via Hiera. This is needed for users with caching_sha2_password hashes (prefixed $A$005$), which are already hashed by MySQL and must not be re-hashed using the mysql_native_password SHA1 logic. Without encrypt_password: false, ProxySQL would store a double-hashed value and all frontend authentication for such users would fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy_mysql_user Ruby type already supports the encrypt_password parameter (lib/puppet/type/proxy_mysql_user.rb), which skips SHA1 hashing when set to false. However, the Proxysql::User Puppet type alias (types/user.pp) did not include it, causing Puppet catalog compilation to fail with "unrecognized key 'encrypt_password'" when the parameter was set via Hiera.
This is needed for users with caching_sha2_password hashes (prefixed $A$005$), which are already hashed by MySQL and must not be re-hashed using the mysql_native_password SHA1 logic. Without encrypt_password: false, ProxySQL would store a double-hashed value and all frontend authentication for such users would fail.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues