Fix Motor toy never scheduling its kickstart/max-runtime alarms#55
Merged
Conversation
The five AlarmHandler Register/UnregisterAlarm sites in Motor were empty `if (m_alarmHandler != nullptr) {}` stubs. With default settings every activation enters kickstart and drives the output to full power, but KickStartEnd is never scheduled -- so the motor/shaker stays pinned at full power instead of dropping to the requested level, and the MaxRunTimeMs safety shutoff never fires. Wire the Register/UnregisterAlarm calls (and the Finish() unregisters) to match Motor.cs.
Collaborator
|
Hello. Thanks for the PR! Converting this to draft as per the contributing rules. (I was behind in getting them added as was just done in Visual Pinball). It's going to take time to review these. libdof is currently is use by several users with a variety of devices, and we have yet to receive issues about this. Also this definitely needs thorough testing with the actual hardware. |
jsm174
marked this pull request as draft
July 5, 2026 18:09
jsm174
marked this pull request as ready for review
July 6, 2026 19:33
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Motor's five
AlarmHandlerregister/unregister sites were emptyif (m_alarmHandler != nullptr) {}stubs. Wire them to scheduleKickStartEnd(kickstart duration) andMaxRunTimeMotorStop(max runtime), and to unregister them on turn-off / inFinish, matchingMotor.cs.Why it matters
With the defaults (KickstartPower 255, KickstartDurationMs 100) every activation enters the kickstart branch and drives the output to full power, but
KickStartEndwas never scheduled — so the motor/shaker stays pinned at full power instead of dropping to the requested level, and theMaxRunTimeMssafety auto-shutoff never fires. The C# class doc explicitly warns that over-driving a shaker "starts to rattle and shake my cab apart."Found by diffing against the DirectOutput C# source.