Fix PinOne swallowing connect failures (zombie updater thread)#56
Merged
Conversation
ConnectToController logged+returned on connect/create-server failure and the catch swallowed without rethrow; PinOne.cs throws on all three. The base updater thread is written to quit when ConnectToController throws -- so with the swallow a failed connect is treated as success and the thread spins against an unconnected port instead of quitting cleanly. Throw on failure and rethrow in the catch to match PinOne.cs.
Collaborator
|
Hello. Thanks for the PR! Converting this to draft as per the contributing rules. (I was behind in getting them added as was just done in Visual Pinball). It's going to take time to review these. libdof is currently is use by several users with a variety of devices, and we have yet to receive issues about this. Also this definitely needs thorough testing with the actual hardware. |
jsm174
marked this pull request as draft
July 5, 2026 18:08
jsm174
marked this pull request as ready for review
July 6, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
ConnectToControllerlogged a warning andreturned on connect/create-server failure, and thecatchswallowed without rethrow.PinOne.csthrows on all three paths. Throw on failure and rethrow in the catch to match.Why it matters
The base updater thread (
OutputControllerCompleteBase) is written to quit cleanly whenConnectToControllerthrows. Because the port swallowed the failure, a failed connect was treated as success — the thread logged "connected" and then spun against an unconnected port (write-fail → catch → disconnect / sleep / reconnect, forever) instead of quitting. Part of the PinOne-on-Linux shutdown-robustness family alongside theSO_RCVTIMEOteardown fix in #53, and the "updater thread did not quit / solenoid stuck on exit" symptoms discussed in #31.Found by diffing against the DirectOutput C# source.