Fix PinscapePico crash when configured device is not connected#58
Merged
Conversation
UpdateOutputs indexes m_oldOutputValues (resized only on a successful connect) and lacked the !m_dev guard the sibling Pinscape has. A configured-but-absent Pico leaves m_dev null, m_oldOutputValues empty, GetNumberOfOutputs()=128, so the first update reads m_oldOutputValues[0] out of bounds and crashes. C# binds the device in the Number setter (Devices.First throws if absent), so it cannot reach this state. Add the !m_dev guard, matching Pinscape::UpdateOutputs.
Collaborator
|
Hello. Thanks for the PR! Converting this to draft as per the contributing rules. (I was behind in getting them added as was just done in Visual Pinball). It's going to take time to review these. libdof is currently is use by several users with a variety of devices, and we have yet to receive issues about this. Also this definitely needs thorough testing with the actual hardware. |
jsm174
marked this pull request as draft
July 5, 2026 18:07
jsm174
marked this pull request as ready for review
July 6, 2026 21:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
UpdateOutputsindexesm_oldOutputValues(resized only on a successful connect) and lacked theif (!m_dev) return;guard the sibling KL25ZPinscapehas. Add it.Why it matters
A configured-but-absent Pico leaves
m_devnull,m_oldOutputValuesempty, andGetNumberOfOutputs()returns 128 — so the first output change readsm_oldOutputValues[0]out of bounds → crash (e.g. aCabinet.xmllisting a Pico that's currently unplugged). C# binds the device in theNumbersetter (Devices.First(...)throws if the unit is absent), so a not-present Pico can never be configured and this state is unreachable.Found by diffing against the DirectOutput C# source.