Fix type mismatch during inital OnAvatarEyeHeightChanged call#119
Merged
momo-the-monster merged 1 commit intovrchat-community:mainfrom Jan 14, 2025
Merged
Conversation
Member
Author
|
I ended up creating a Canny post at the same time but forgot to link it here: |
Nestorboy
changed the title
momo-the-monster
approved these changes
Jan 14, 2025
Collaborator
|
Merging in since we haven't synced the upstream fix to this repo yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a player joins,
OnAvatarEyeHeightChangedis invoked with theprevEyeHeightAsMetersparameter passed as the literal integer 0, causing a type mismatch since it is expected to be a float.The issue was brought to my attention by another user using one of my prefabs:
Nestorboy/NUMovement#3