Skip to content

fix(DialogContent): pass scrim: false through the stack ticket #910

Description

@johnleider

Surfaced by @paper/bulma in #760.

useStack already supports scrim on a ticket (SnackbarPortal uses it). DialogContent.register() does not pass scrim: false, so an app that mounts the global <Scrim> paints a second backdrop behind every BuModal — which has to hand-roll .modal-background because Scrim is global/per-ticket and cannot serve as an in-flow per-modal element.

Emerald dodges this with native ::backdrop.

Expected

DialogContent should opt a ticket out of the global Scrim (scrim: false), or expose that as a prop, so a consumer that owns its own backdrop is not double-dimmed.

Cheap because the stack already has the flag.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C: DialogDialog componentT: bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions