Distributable packaging - #5
Closed
vxel wants to merge 3 commits into
Closed
Conversation
vxel
added a commit
that referenced
this pull request
Jul 4, 2026
Quality gate on PR #5 failed on two conditions: - new_reliability_rating (bug java:S5850): the id-slug regex "(^-+|-+$)" mixed anchors with an alternation, leaving the operator precedence implicit. Rewrite as "(?:^-+)|(?:-+$)" (same behaviour: trim leading/trailing dashes). - new_duplicated_lines_density (4.1% > 3%): extract the duplicated UI code shared by the Creations feature and the World* states into: * AbstractPreviewProcessor - no-op SceneProcessor stubs, extended by CreationPreview and WorldPreview. * CardGrid - the framed preview+caption card builder and the drag-to-scroll / tap-to-select cursor listener, decoupled from its host via the ScrollableGrid interface (implemented by WorldMenuState and CreationLibraryState). * ScreenState.registerOn/unregisterFrom - the register/unregister lifecycle boilerplate, reused by CreationLibraryState and CreationCaptureState. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vxel
added a commit
that referenced
this pull request
Jul 4, 2026
Quality gate on PR #5 failed on two conditions: - new_reliability_rating (bug java:S5850): the id-slug regex "(^-+|-+$)" mixed anchors with an alternation, leaving the operator precedence implicit. Rewrite as "(?:^-+)|(?:-+$)" (same behaviour: trim leading/trailing dashes). - new_duplicated_lines_density (4.1% > 3%): extract the duplicated UI code shared by the Creations feature and the World* states into: * AbstractPreviewProcessor - no-op SceneProcessor stubs, extended by CreationPreview and WorldPreview. * CardGrid - the framed preview+caption card builder and the drag-to-scroll / tap-to-select cursor listener, decoupled from its host via the ScrollableGrid interface (implemented by WorldMenuState and CreationLibraryState). * ScreenState.registerOn/unregisterFrom - the register/unregister lifecycle boilerplate, reused by CreationLibraryState and CreationCaptureState. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vxel
force-pushed
the
distributable-packaging
branch
from
July 4, 2026 16:04
1029f01 to
7e31cd6
Compare
vxel
added a commit
that referenced
this pull request
Jul 4, 2026
Quality gate on PR #5 failed on two conditions: - new_reliability_rating (bug java:S5850): the id-slug regex "(^-+|-+$)" mixed anchors with an alternation, leaving the operator precedence implicit. Rewrite as "(?:^-+)|(?:-+$)" (same behaviour: trim leading/trailing dashes). - new_duplicated_lines_density (4.1% > 3%): extract the duplicated UI code shared by the Creations feature and the World* states into: * AbstractPreviewProcessor - no-op SceneProcessor stubs, extended by CreationPreview and WorldPreview. * CardGrid - the framed preview+caption card builder and the drag-to-scroll / tap-to-select cursor listener, decoupled from its host via the ScrollableGrid interface (implemented by WorldMenuState and CreationLibraryState). * ScreenState.registerOn/unregisterFrom - the register/unregister lifecycle boilerplate, reused by CreationLibraryState and CreationCaptureState. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vxel
force-pushed
the
distributable-packaging
branch
from
July 4, 2026 16:07
7e31cd6 to
095d9fe
Compare
Quality gate on PR #5 failed on two conditions: - new_reliability_rating (bug java:S5850): the id-slug regex "(^-+|-+$)" mixed anchors with an alternation, leaving the operator precedence implicit. Rewrite as "(?:^-+)|(?:-+$)" (same behaviour: trim leading/trailing dashes). - new_duplicated_lines_density (4.1% > 3%): extract the duplicated UI code shared by the Creations feature and the World* states into: * AbstractPreviewProcessor - no-op SceneProcessor stubs, extended by CreationPreview and WorldPreview. * CardGrid - the framed preview+caption card builder and the drag-to-scroll / tap-to-select cursor listener, decoupled from its host via the ScrollableGrid interface (implemented by WorldMenuState and CreationLibraryState). * ScreenState.registerOn/unregisterFrom - the register/unregister lifecycle boilerplate, reused by CreationLibraryState and CreationCaptureState. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vxel
force-pushed
the
distributable-packaging
branch
from
July 4, 2026 16:17
095d9fe to
6a808fc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.