Repository navigation
Health findings as events - #81
Merged
Merged
Conversation
warden posts an event when a port changes hands, when a node goes quiet, when a ruleset is applied and when one rolls itself back. It said nothing at all when it noticed something was wrong - `warden doctor` knew the webhook had not arrived since Tuesday and only said so if somebody typed the command. That is backwards: the point of an event stream is not having to ask. The checks doctor runs now happen on a timer inside `warden serve`, and a finding that changes state is an event like any other. `health.worsened` and `health.recovered`, subject being which check it was, body carrying the level and the words it said. On change only. A channel told every ten minutes that three rules are still unapplied is a channel people mute within the week, which is why `port.renewed` is not posted by default either. A `warn` that becomes a `fail` is worth saying again, a `note` is not worth saying at all, and the first look after a start is quiet - what a machine was already like is not news, and a deploy that restarts four wardens should not be four messages. It leaves the sockets alone. Walking every socket every ten minutes to say the same thing is a cost `/metrics` already refuses to pay, so the timer counts registrations and `warden doctor` still checks the holders when a person asks. `health_watch` turns it off, `health_interval` is how far apart it looks, and a check now says which one it was so one finding changing can be told from another one appearing. Closes #75
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warden posts an event when a port changes hands, when a node goes quiet, when a ruleset is applied and when one rolls itself back. It said nothing at all when it noticed something was wrong —
warden doctorknew the webhook had not arrived since Tuesday, that three rules had been sitting unapplied for two days, that this warden is reachable with no token, and it only said so if somebody typed the command.core/rounds.py— the checks doctor runs, on a timer insidewarden serve, announcing a finding when it changes state.healthscope, with their own colour, icon and words in all four webhook shapes. Subject is which check it was, body carries the level and what it said.Checknow says which check it was, so one finding changing can be told from another one appearing.health_watch(default on) andhealth_interval(default 600s, at least 60).On change only. A channel told every ten minutes that three rules are still unapplied is a channel people mute within the week — the same reason
port.renewedis not posted by default. Awarnthat becomes afailis worth saying again; anoteis not worth saying at all; and the first look after a start is quiet, because what a machine was already like is not news and a deploy that restarts four wardens should not be four messages.It leaves the sockets alone. Walking every socket every ten minutes to say the same thing is a cost
/metricsalready refuses to pay, soexamine(sweeping=False)counts registrations instead.warden doctorstill checks the holders when a person asks.16 tests in
tests/test_health_events.py. README, Events and webhooks, and Configuration say it.Closes #75