Repository navigation
ci: measure the semver gate against 0.7.0 - #164
Merged
Merged
Conversation
The post-publish step from docs/RELEASING.md: the literal moves once the crates are on the index, never before, because the job downloads the baseline from crates.io. Left at 0.6.1 it would carry this release's own intended breaks forward as if they were new, and every pull request would be measured against a release that is no longer the last one. Checked at the new baseline: five crates, no semver update required, forced to --release-type patch. Signed-off-by: Vyncint Ng <chivy.nguyen@manabie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-publish step from
docs/RELEASING.md. The literal moves after the crates are on the index, never before — the job downloads the baseline from crates.io, so bumping it early fails every check.Left at 0.6.1 it would carry 0.7.0's own intended breaks forward as if they were new, and every pull request from here would be measured against a release that is no longer the last one.
Forced to
patch, which is the strict form: it excuses no API change of any kind.