Skip to content

Update actions and restrict deployment#657

Merged
infojunkie merged 5 commits into
w3c-cg:gh-pagesfrom
rettinghaus:workflow
Jun 16, 2026
Merged

Update actions and restrict deployment#657
infojunkie merged 5 commits into
w3c-cg:gh-pagesfrom
rettinghaus:workflow

Conversation

@rettinghaus

Copy link
Copy Markdown
Contributor

This PR updates the used actions to their latest main versions and restricts build and deploy to this repo (to not attempt to run on forks).

@infojunkie

infojunkie commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Thanks. We don't want to restrict build / deploy to w3c-cg only, because other contributors might want their PRs to be deployed to their own pages, e.g. https://github.com/davidmatthew-ie/musicxml => https://davidmatthew-ie.github.io/musicxml/

I wonder what other mechanisms could be used to inhibit these steps for those who don't want it. For example:

  • An explicit env var like SKIP_DEPLOY in the fork that would be used in the GitHub workflow's if: condition
  • Reuse the existing env var ORIGIN with a special value like none / skip, etc.
  • Detect (in the workflow) that the fork's Pages settings is not configured for publishing as per screenshot below
Screenshot from 2026-06-15 09-07-25

What do you think @rettinghaus ?

@rettinghaus

Copy link
Copy Markdown
Contributor Author

Good point. It failed for me, because I hadn't switched it over to the workflow. I commented the condition out for now until we agreed on a good way to make it optional on forks.

@infojunkie

infojunkie commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Unless you don't think it's a good idea, let's use vars.ORIGIN as the deciding factor to proceed with build step. It has to be set and non-empty to proceed.

Also, please document this additional behaviour at https://github.com/w3c-cg/musicxml/tree/gh-pages/docs#deployment :

  • If ORIGIN is left unset or blank, the GitHub CI/CD will not proceed with build / deploy steps.

@infojunkie

Copy link
Copy Markdown
Contributor

Thanks @rettinghaus for the latest updates. Do you confirm that leaving ORIGIN undefined does not trigger the build step in your fork?

@rettinghaus

Copy link
Copy Markdown
Contributor Author

confirmed!

@infojunkie infojunkie merged commit afdde3c into w3c-cg:gh-pages Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants