Use SecurityError for document state check #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
requested review from
RByers,
samuelgoto and
timcappalli
as code owners
OR13
approved these changes
Aug 1, 2024
timcappalli
approved these changes
Aug 2, 2024
Collaborator
Author
|
Blocked on tests and updating implementations. |
Collaborator
Author
|
@samuelgoto, you ok with this change? If yes, I'll make them also in WebKit. |
Contributor
Sounds reasonable to me to be more specific than |
samuelgoto
approved these changes
Aug 22, 2024
samuelgoto
approved these changes
Oct 21, 2024
Contributor
samuelgoto
left a comment
samuelgoto
left a comment
There was a problem hiding this comment.
I don't feel strongly about this, seems like a reasonable differentiation between errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have an over-reliance on NotAllowedError (particularly in Cred Man). This makes things a bit more distinguishable (for interop testing), and lets developers know a bit more about what's going on.
The following tasks have been completed:
Implementation commitment:
Documentation and checks
Preview | Diff