Add did:verifiedcar DID Method - #671
Conversation
ottomorac
left a comment
There was a problem hiding this comment.
Hi @thevowtechs-lgtm ,
Good day Sir. I have performed an initial review.
Please address the following items:
1 - For each DID method operation that you support (Create, Read, Update, and Deactivate DID Method Operations). You should provide more detail of how they function, currently you have online like 2 lines for each.
See some suggested examples here:
https://docs.cheqd.io/product/architecture/adr-list/adr-001-cheqd-did-method#verification-method
https://identity.foundation/didwebvh/v1.0/#did-method-operations
https://github.com/iden3/did-iden3/blob/main/did-iden3-method.md#basic-operations
2 - The Security and Privacy considerations section could use more detail .
These are important before we merge this did method into the spec-registries.
Some examples here:
https://github.com/iden3/did-iden3/blob/main/did-iden3-method.md#security-and-privacy-considerations
https://docs.cheqd.io/product/architecture/adr-list/adr-001-cheqd-did-method#security-considerations
https://identity.foundation/didwebvh/v1.0/#security-considerations
3 - Finally, deactivation via email seems unusual. The deactivate step is technically permissible under Section 7.2 of the W3C DID spec because "out-of-band mechanisms" are explicitly allowed, however it presents security risks.
I might recommend that you either not support deactivation, or perhaps consider another method for deactivation. If you insist on using email method for de-activation then the Security Considerations section must explicitly address:
-
How the authority prevents email spoofing (e.g., enforcing PGP-signed emails, or strict DKIM/SPF/DMARC verification).
-
How it guarantees integrity protection so an attacker cannot forge a deactivation request.
-
How it mitigates Denial of Service (DoS) attacks on the hardcodedlogic.com email inbox.
This Pull Request proposes registration of the did:verifiedcar method.
Specification: https://verifiedcar.com/spec/
Resolver: https://verifiedcar.com/resolve/did:verifiedcar:root
Well-known DID: https://verifiedcar.com/.well-known/did.json
Contact: authority@hardcodedlogic.com
Repository: https://github.com/thevowtechs-lgtm/Did-verifiedcar
The JSON file has been validated against the registry requirements and all automated tests pass.
DID Method Registration
As a DID method registrant, I have ensured that my DID method registration complies with the following statements:
contactEmailaddress [OPTIONAL].verifiableDataRegistryentry [OPTIONAL].