Fixes a duplicate id added in PR 331 - #334
Merged
Merged
Conversation
Signed-off-by: Stephen Curran <swcurran@gmail.com>
swcurran
requested review from
dmitrizagidulin,
mccown,
msporny,
ottomorac and
wip-abramson
as code owners
May 25, 2026 16:44
Contributor
|
Thanks for this! Sorry I missed it. I think for these kinds of changes @swcurran you should be able to just push to main as its editorial. I also wonder if there is a way to run the build on the PR so we know if fails before pushing. I have run into this before, maybe there is some pre step I should be doing locally. But it does feel like something we could have a github action for. |
wip-abramson
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a duplicate
idthat was added in PR #331.Signed-off-by: Stephen Curran swcurran@gmail.com
Preview | Diff