I have a terminological issue. You use the expression "credentialSubject type" all over the place, and this does not sound right to me. credentialSubject is a property which, in this respect, does not have a "type". It is the value (a.k.a. "object") of that property that has a type and that is what you are talking about.
I am not sure what the best way is to change this. Maybe the simplest thing is not to use "credentialSubject type" just "credential subject type" (or maybe simply "subject type"), with the first occurrence linked to the reference above to the VCDM spec.
Originally posted by @iherman in #59 (review)
I have a terminological issue. You use the expression "
credentialSubjecttype" all over the place, and this does not sound right to me.credentialSubjectis a property which, in this respect, does not have a "type". It is the value (a.k.a. "object") of that property that has a type and that is what you are talking about.I am not sure what the best way is to change this. Maybe the simplest thing is not to use "
credentialSubjecttype" just "credential subject type" (or maybe simply "subject type"), with the first occurrence linked to the reference above to the VCDM spec.Originally posted by @iherman in #59 (review)