fix(integrations): Windows / Git Bash client support (tier-2) - #13
Merged
Conversation
- codex installer: placeholder substitution via Python (py -3 fallback) instead of sed -i.bak, which MSYS sed mishandles; sed kept as POSIX fallback (closes #3) - state files: new shared lib/state-paths.mjs resolves XDG_STATE_HOME -> %LOCALAPPDATA% (win32) -> ~/.local/state; used by nudge-lib, recall-state, precompact-state; added to the parity SHARED list (closes #5, closes #8) - ci: windows-latest Git Bash job runs hook smoke, unit/parity tests, and both installers end-to-end with stubbed CLIs - readme: explicit Platform support section (Windows = Docker Desktop WSL2 server + Git Bash clients) Reported by @pizofreude in #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the Windows/Git Bash compat group from #1, reported by @pizofreude.
What changed
py -3fallback for Git Bash, wherepython3isn't on PATH) instead ofsed -i.bak;sedremains only as a fallback for minimal POSIX hosts. The native-memory enable and config write share the same dispatcher.lib/state-paths.mjs—XDG_STATE_HOME→%LOCALAPPDATA%(win32) →~/.local/state. Used bynudge-lib.mjs,recall-state.mjs,precompact-state.mjs; added to theSHAREDbyte-parity list as suggested in claude-code + codex: share a state-path helper with Windows fallback #8.windows-smokejob onwindows-latest(Git Bash) — hook-script smoke, unit/parity tests, and both client installers end-to-end with stubbedcodex/hermesCLIs.Verification
node --test integrations/tests/— 14/14 pass locally (incl. new state-path + parity tests)CODEX_HOME: exit 0, zero leftover placeholders, valid config JSONwindows-smokeCI job on this PR is the real Git Bash verificationCloses #3, closes #5, closes #8.