Repository navigation
[release-6.x] Make the L3 regression goldens HBase-2.x- and WHPG-7-neutral (regression/ from main) - #91
Merged
Conversation
…utral (regression/ from main) Backport of the regression/ part of #2, with the psql `\! ` spacing from #52 and the README wording from #48 riding along; the tree is byte-identical to main's regression/ after this. No product code changes. The packaging smoke now runs L3 on this branch (whpg-extensions-packaging PR 141, PTT-1888) against the HBase 2.6.5 / Hive 3.1.3 cluster it has always stood up for the 6.x server, and the goldens failed on output noise alone (run 38720716273): - HBaseSmokeTest / FDW_HBaseSmokeTest: 506 "0 row(s) in -.---- seconds" lines the HBase 1.x shell printed per put() and 2.x does not; on WHPG 7 also 10.01 vs 10.009999999999998 (PG12 extra_float_digits default 1 -> 3). Fixed by silencing gen_small_data.rb and SET extra_float_digits = 0. - HiveSmokeTest: HiveServer2's INFO lines echoed by beeline. Fixed by wrapping the beeline calls in start_ignore / end_ignore. - init_file: the SLF4J "Actual binding" line is matched for any binding, not only Log4jLoggerFactory. main's regression/ runs green on WHPG 6 and 7 every week, so the same files are safe on both majors here.
adam8157
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The packaging smoke now runs L3 (
regression/) on the 6.x line (EnterpriseDB/whpg-extensions-packaging#141, PTT-1888), against the HBase 2.6.5 / Hive 3.1.3 cluster it has always stood up for the 6.x server. This branch's goldens failed on output noise alone, on both WHPG majors (packaging run 38720716273 / 38720721766):HBaseSmokeTest,FDW_HBaseSmokeTest0 row(s) in -.---- secondslines the HBase 1.x shell printed perput(); 2.x prints none. On WHPG 7 also10.01vs10.009999999999998(PG12 raised theextra_float_digitsdefault from 1 to 3)HiveSmokeTestINFO : Compiling command(...)lines echoed by beelinemainfixed all of these in #2 (silencegen_small_data.rb,SET extra_float_digits = 0,start_ignorearound the beeline calls,init_filematching any SLF4J binding) and that tree runs green on WHPG 6 and 7 in the weekly packaging matrix.What
regression/taken verbatim frommain(git checkout origin/main -- regression): the #2 changes above, plus the\!→\!psql spacing from #52 and the README wording from #48. 22 files, no product code. After this the directory is byte-identical tomain's.Verification
Packaging dispatch of this branch as
pxf-version,whpg-version: both, from whpg-extensions-packaging PR 141 — links in that PR.