Add Hermes CLI-agent notification support#10001
Add Hermes CLI-agent notification support#10001majal wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @majal on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
There was a problem hiding this comment.
Overview
This PR adds Hermes as a recognized CLI-agent identity and wires it through event parsing, telemetry, listener support, plugin-manager exclusion, and rich-input submit behavior, with focused unit coverage.
Concerns
- No screenshots or video were provided for the user-visible Hermes notification/rich-input behavior. Per Warp review guidance, please upload visual evidence of the feature working end to end.
- Security pass: no security findings in the changed lines.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Contributor-side update:
Could a maintainer approve the pending workflows when convenient? |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @harryalbert. Comment Powered by Oz |
Oz no longer requests changes for this pull request after the latest automated review.
There was a problem hiding this comment.
Overview
This PR adds Hermes as a recognized CLI agent throughout command detection, structured event parsing, rich-status listener support, telemetry mapping, plugin-manager exclusion, rich-input submit strategy, and focused tests.
Concerns
- No blocking correctness or security concerns found in the reviewed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Summary
Adds Hermes Agent as a recognized Warp CLI agent for structured CLI-agent notification events.
Changes:
CLIAgent::Hermeswith command prefixhermes, display name, brand color, skill provider, and telemetry mappingagent: "hermes"in structuredwarp://cli-agentOSC payloads via the normal command-prefix resolverThis is the Warp-side half of Hermes Warp Agent Notifications support. The matching Hermes-side PR emits
ESC ] 777 ; notify ; warp://cli-agent ; <json> BELevents withagent: "hermes".Related:
Verification
cargo fmt --checkpassedgit diff --checkpassedcargo test -p warp parses_hermes_agent_from_command_prefix --lib, but local verification is blocked by the environment:crates/warpui/build.rsrequires Xcode'smetalutility, and this machine only has CommandLineTools withoutmetal.