Skip to content

Add Hermes CLI-agent notification support#10001

Open
majal wants to merge 1 commit intowarpdotdev:masterfrom
majal:feat/hermes-cli-agent-notifications
Open

Add Hermes CLI-agent notification support#10001
majal wants to merge 1 commit intowarpdotdev:masterfrom
majal:feat/hermes-cli-agent-notifications

Conversation

@majal
Copy link
Copy Markdown

@majal majal commented May 4, 2026

Summary

Adds Hermes Agent as a recognized Warp CLI agent for structured CLI-agent notification events.

Changes:

  • add CLIAgent::Hermes with command prefix hermes, display name, brand color, skill provider, and telemetry mapping
  • parse agent: "hermes" in structured warp://cli-agent OSC payloads via the normal command-prefix resolver
  • route Hermes through the default CLI-agent session listener/rich-status path
  • keep Hermes out of bundled plugin install flows (Hermes emits events itself)
  • include Hermes in rich-input delayed-enter handling
  • add focused tests for command detection, event parsing, support, and default listener forwarding

This is the Warp-side half of Hermes Warp Agent Notifications support. The matching Hermes-side PR emits ESC ] 777 ; notify ; warp://cli-agent ; <json> BEL events with agent: "hermes".

Related:

Verification

  • cargo fmt --check passed
  • git diff --check passed
  • Independent review passed with no blocking issues
  • Tried cargo test -p warp parses_hermes_agent_from_command_prefix --lib, but local verification is blocked by the environment: crates/warpui/build.rs requires Xcode's metal utility, and this machine only has CommandLineTools without metal.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 4, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @majal on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 4, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 4, 2026

@majal

I'm starting a first review of this pull request.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss[bot]
oz-for-oss Bot previously requested changes May 4, 2026
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds Hermes as a recognized CLI-agent identity and wires it through event parsing, telemetry, listener support, plugin-manager exclusion, and rich-input submit behavior, with focused unit coverage.

Concerns

  • No screenshots or video were provided for the user-visible Hermes notification/rich-input behavior. Per Warp review guidance, please upload visual evidence of the feature working end to end.
  • Security pass: no security findings in the changed lines.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@majal
Copy link
Copy Markdown
Author

majal commented May 4, 2026

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label May 4, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 4, 2026

The cla-bot has been summoned, and re-checked this pull request!

@majal
Copy link
Copy Markdown
Author

majal commented May 4, 2026

Contributor-side update:

  • CLA is now green (verification/cla-signed).
  • The remaining required Check CI results status appears blocked because the GitHub Actions runs are waiting for maintainer approval. I tried approving the pending workflow runs, but this account does not have the required maintainer/admin permission (HTTP 403).
  • Local validation completed: WarpOss build/bundle, git diff --check, cargo fmt --check, and Hermes-side pytest/py_compile passed.
  • Oz's only requested change is visual evidence for the user-visible behavior. I will not spend another limited Oz rerun until truthful visual evidence can be attached or maintainers say the validation above is enough.

Could a maintainer approve the pending workflows when convenient?

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 4, 2026

@majal

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @harryalbert.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot dismissed their stale review May 4, 2026 04:23

Oz no longer requests changes for this pull request after the latest automated review.

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds Hermes as a recognized CLI agent throughout command detection, structured event parsing, rich-status listener support, telemetry mapping, plugin-manager exclusion, rich-input submit strategy, and focused tests.

Concerns

  • No blocking correctness or security concerns found in the reviewed diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from harryalbert May 4, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant