fix(ui): Correct context chip styling during active CLI agent sessions #9968
fix(ui): Correct context chip styling during active CLI agent sessions #9968PratikRai0101 wants to merge 3 commits intowarpdotdev:masterfrom
Conversation
…s (Fixes Bug 3 from warpdotdev#9958)
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR gates hover, cursor, color, and click affordances for the Git Branch, Working Directory, and Node Version context chips while a CLI agent session is active.
Concerns
- The Node Version popup can remain mounted and actionable if it was already open when the CLI agent session becomes active, so users can still trigger version/install actions during the disabled state.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR mutes and disables click/hover behavior on Git Branch, Working Directory, and Node Version context chips while a CLI agent session is active. The change does not introduce security-sensitive behavior.
Concerns
- Working Directory's agent-view disabled color path merges CLI-agent and ambient-agent cases, so CLI-agent chips in agent view do not use
internal_colors::neutral_6consistently with Git Branch and Node Version. - Git Branch and Working Directory still render their already-open menus when a CLI agent session becomes active; unlike Node Version's
popup_open && !is_cli_agent_activegate, those overlays can remain visible/focusable even though chip actions are supposed to be suppressed.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers. Comment Powered by Oz |
oz-for-oss
Bot
dismissed stale reviews from themself
Oz no longer requests changes for this pull request after the latest automated review.
There was a problem hiding this comment.
Overview
This PR updates the Git Branch, Working Directory, and Node Version context chips so CLI-agent-active sessions render them as non-interactive: muted color, no hover affordance/tooltips, no pointing cursor, and no menu/popup overlay while active.
Concerns
- No blocking correctness or security concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
oz-for-oss
Bot
requested review from
a team and
peicodes
and removed request for
a team
1 participant
fix(ui): Correct context chip styling during active CLI agent sessions
Description
This PR addresses Bug 3 from issue #9958, where context chips (badges) in the CLI agent toolbar appeared interactive despite their click actions being suppressed.
The fix ensures that the UI correctly reflects the disabled state when a CLI agent session is active by:
PointingHandto a defaultArrow.internal_colors::neutral_6to provide a muted, "disabled" visual style for the text and icons.These changes were applied to the Git Branch, Working Directory, and Node Version chips in
app/src/context_chips/display_chip.rs.Linked Issue
Addresses Bug 3 in #9958
ready-to-specorready-to-implement.Screenshots / Videos
N/A - Functional UI state and color logic update.
Testing
Verified the implementation by checking the rendering logic in
display_chip.rs. Confirmed thatis_cli_agent_activenow gates all interactive UI properties (hover, cursor, click) and triggers the muted color palette.Agent Mode
Changelog Entries for Stable
CHANGELOG-BUG-FIX: Fixed a UI mismatch where certain toolbar context chips (Git Branch, Working Directory, Node Version) appeared falsely clickable during active CLI agent sessions.