fix(grid): add box-drawing characters to FILE_LINK_SEPARATORS#9975
Open
rndjams wants to merge 1 commit intowarpdotdev:masterfrom
Open
fix(grid): add box-drawing characters to FILE_LINK_SEPARATORS#9975rndjams wants to merge 1 commit intowarpdotdev:masterfrom
rndjams wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
Adds Unicode box-drawing characters (single and double-line variants) to the file-link separator set so that tree/eza --tree/lsd --tree output filenames are tokenized as standalone clickable candidates. Previously, rows like '│ └── alpha.md' were treated as a single token because │, ├, └, ─ were not in the separator set. Closes warpdotdev#9909
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR adds box-drawing characters to FILE_LINK_SEPARATORS so tree-style terminal output can produce standalone clickable file path candidates, and includes focused unit coverage for single-line and double-line tree prefixes.
Concerns
- No blocking correctness or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Unicode box-drawing characters (single and double-line variants) to
FILE_LINK_SEPARATORSso thattree,eza --tree, andlsd --treeoutput filenames are tokenized as standalone clickable candidates.Previously, rows like
│ └── alpha.mdwere treated as a single token because│,├,└,─were not in the separator set, making filenames in tree output never clickable.Characters added:
│ ├ └ ─ ┬ ┴ ┼ ┌ ┐ ┘║ ╠ ╚ ═ ╦ ╩ ╬ ╔ ╗ ╝Linked Issue
Closes #9909
ready-to-specorready-to-implement.Testing
grid_handler_test.rs:test_box_drawing_chars_are_link_separators—│ └── alpha.mdproducesalpha.mdas candidatetest_box_drawing_tree_branch_with_directory—├── srcproducessrcas candidatetest_double_line_box_drawing_separators—║ ╚══ notes.txtproducesnotes.txtas candidatecargo fmt -- --check— clean.Agent Mode
CHANGELOG-BUG-FIX: Fixed
treeoutput filenames not being clickable due to box-drawing characters not being recognized as link separators.