Skip to content

fix(grid): add box-drawing characters to FILE_LINK_SEPARATORS#9975

Open
rndjams wants to merge 1 commit intowarpdotdev:masterfrom
rndjams:rndjams/fix-tree-box-drawing-separators
Open

fix(grid): add box-drawing characters to FILE_LINK_SEPARATORS#9975
rndjams wants to merge 1 commit intowarpdotdev:masterfrom
rndjams:rndjams/fix-tree-box-drawing-separators

Conversation

@rndjams
Copy link
Copy Markdown

@rndjams rndjams commented May 3, 2026

Description

Adds Unicode box-drawing characters (single and double-line variants) to FILE_LINK_SEPARATORS so that tree, eza --tree, and lsd --tree output filenames are tokenized as standalone clickable candidates.

Previously, rows like │ └── alpha.md were treated as a single token because , , , were not in the separator set, making filenames in tree output never clickable.

Characters added:

  • Single-line: │ ├ └ ─ ┬ ┴ ┼ ┌ ┐ ┘
  • Double-line: ║ ╠ ╚ ═ ╦ ╩ ╬ ╔ ╗ ╝

Linked Issue

Closes #9909

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • 3 new unit tests in grid_handler_test.rs:
    • test_box_drawing_chars_are_link_separators│ └── alpha.md produces alpha.md as candidate
    • test_box_drawing_tree_branch_with_directory├── src produces src as candidate
    • test_double_line_box_drawing_separators║ ╚══ notes.txt produces notes.txt as candidate
  • cargo fmt -- --check — clean.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Fixed tree output filenames not being clickable due to box-drawing characters not being recognized as link separators.

Adds Unicode box-drawing characters (single and double-line variants)
to the file-link separator set so that tree/eza --tree/lsd --tree
output filenames are tokenized as standalone clickable candidates.

Previously, rows like '│   └── alpha.md' were treated as a single
token because │, ├, └, ─ were not in the separator set.

Closes warpdotdev#9909
@cla-bot cla-bot Bot added the cla-signed label May 3, 2026
@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 3, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 3, 2026

@rndjams

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds box-drawing characters to FILE_LINK_SEPARATORS so tree-style terminal output can produce standalone clickable file path candidates, and includes focused unit coverage for single-line and double-line tree prefixes.

Concerns

  • No blocking correctness or security concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested review from a team and lucieleblanc and removed request for a team May 3, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Box-drawing characters not recognized as link separators; tree output never clickable

1 participant